fix: Fix mypy TorchTensor type alias error by nithin42 · Pull Request #6712 · feast-dev/feast

nithin42 · 2026-08-07T19:06:20Z

What this PR does / why we need it

In online_response.py, TorchTensor is defined using TypeAlias inside both conditional branches of if TYPE_CHECKING:. Mypy complains: Variable "feast.online_response.TorchTensor" is not valid as a type because it parses it as a variable inside the runtime fallback branch.
This PR fixes the typing syntax in online_response.py by defining TorchTensor cleanly without TypeAlias in the fallback branch so mypy parses the type correctly.

Which issue(s) this PR fixes

Fixes #5563

Checks

I've made sure the tests are passing.
My commits are signed off (git commit -s)
My PR title follows conventional commits format

jyejare

LGTM, just nitpick.

jyejare · 2026-08-10T10:53:10Z

@@ -26,10 +26,9 @@

 if TYPE_CHECKING:
    import torch


This must not be needed anymore.

nithin42 · 2026-08-10T11:28:15Z

Good catch — removed the redundant import torch in commit 2704e66. Since TorchTensor is the only torch symbol used in type annotations, the standalone module import was indeed no longer needed after the fix.

Fix the TypeAlias annotation of TorchTensor in the fallback branch of online_response.py to stop mypy from treating it as a variable and raising 'not valid as a type'. Fixes feast-dev#5563 Signed-off-by: Nithin <kumbam.nithingoud@gmail.com>

The bare `import torch` statement inside the `if TYPE_CHECKING:` branch was superseded by `from torch import Tensor as TorchTensor` on the following line. Since `TorchTensor` is the only torch symbol referenced in type annotations, the standalone module import is unnecessary and can be dropped without affecting runtime or static-analysis behaviour. Addresses nitpick raised in code review. Signed-off-by: Nithin <kumbam.nithingoud@gmail.com>

nithin42 · 2026-08-10T12:15:31Z

@jyejare @ntkathole @franciscojavierarceo — the nitpick is fixed and DCO is green. Could you please approve the workflow runs for this PR so CI can finish and it can be merged? Thank you!

codecov-commenter · 2026-08-10T13:55:55Z

⚠️ Please install the $'codecov app svg image'$ to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.76%. Comparing base (037c4cd) to head (a0c040f).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

$Impacted file tree graph$

@@           Coverage Diff           @@
##           master    #6712   +/-   ##
=======================================
  Coverage   46.76%   46.76%           
=======================================
  Files         415      415           
  Lines       50392    50392           
  Branches     7214     7214           
=======================================
  Hits        23567    23567           
  Misses      25171    25171           
  Partials     1654     1654

Flag	Coverage Δ
go-feature-server	`30.58% <ø> (ø)`
python-unit	`48.09% <100.00%> (ø)`

Files with missing lines	Coverage Δ
sdk/python/feast/online_response.py	`75.36% <100.00%> (ø)`

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 037c4cd...a0c040f. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# [0.66.0](v0.65.0...v0.66.0) (2026-08-21) ### Bug Fixes * Add connection pre-warming for DynamoDB async client ([89240fa](89240fa)), closes [#6060](#6060) * Add remote registry client extra ([#6697](#6697)) ([b8dfcb0](b8dfcb0)) * Address review feedback on FIPS cipher suite configuration ([4a35fba](4a35fba)) * Allow remote-registry first apply for new projects ([39d408d](39d408d)) * Avoid importing feast.feature_store at mcp_server import time ([ddb2e9a](ddb2e9a)) * Bump pymssql to >=2.3.6 for macOS arm64 wheel support ([181eb35](181eb35)), closes [#5636](#5636) [#5193](#5193) [#5636](#5636) * Call ApplySavedDataset RPC instead of ApplyFeatureService in RemoteRegistry.apply_saved_dataset() ([934d341](934d341)) * Catch missing dbt parser dependency in dbt CLI commands ([#6534](#6534)) ([3c2ae3c](3c2ae3c)) * Default authentication to kubernetes auth ([6a4690a](6a4690a)) * Defer feature-freshness thread to post-fork to avoid Gunicorn deadlock ([#6648](#6648)) ([104ad10](104ad10)), closes [#6647](#6647) * Do not pass undeclared feature view columns to ODFV UDFs ([#6527](#6527)) ([75b9463](75b9463)) * downgrade mcp pin to 1.29.0 and fix CI lockfiles and unit tests ([98e5bca](98e5bca)), closes [#6706](#6706) * Feast apply silently ignoring ttl updates to None or timedelta(0) ([#6709](#6709)) ([97b0f25](97b0f25)), closes [#6703](#6703) * Fix mypy TorchTensor type alias error ([#6712](#6712)) ([34de6fa](34de6fa)), closes [#5563](#5563) * Fixed data source creation form gaps ([5d0f7d6](5d0f7d6)) * Handle parameterized and complex Trino types in type map ([326554d](326554d)) * Isolate default user permissions ([e37adbf](e37adbf)) * Isolate projection join key maps ([d1c709d](d1c709d)) * Map Postgres real to FLOAT instead of DOUBLE ([62db435](62db435)) * Merge shared ODFV source projections in feature resolution ([d269946](d269946)), closes [#6621](#6621) * More exhaustive athena types ([a9aaefc](a9aaefc)) * Normalize SQL registry read_path to the psycopg3 driver like path ([#6644](#6644)) ([996c6ea](996c6ea)), closes [#6643](#6643) * **operator:** add spec.services.onlineStore.disabled to opt out of the online store ([d81d4e3](d81d4e3)), closes [#6586](#6586) * Preinstall DuckDB delta extension for tests ([fd4d49d](fd4d49d)), closes [#6743](#6743) * Preserve event-time ordering within Redis online_write_batch ([40fb788](40fb788)), closes [#5163](#5163) * Prevent mutation of cached feature resolution results ([ea17419](ea17419)) * Remote feastRef FeatureStore fails first apply for a new feastProject ([9affee5](9affee5)) * Remove inert subjectaccessreviews and reorganize RBAC rules ([f771ea4](f771ea4)) * Report single-feature-view spark_application materialization success ([a9219d9](a9219d9)), closes [#6673](#6673) * Reset the global security manager after the permissions fixture ([7667215](7667215)) * Resolve kserve with pip --dry-run instead of installing it ([01da132](01da132)), closes [#6732](#6732) * Resolve write_to_offline_store feature view with a single registry lookup ([a42dc85](a42dc85)), closes [#4235](#4235) * Return False from __eq__ on cross-type comparison ([#6637](#6637)) ([0f149a9](0f149a9)), closes [#6636](#6636) * Reuse IdP-issued client tokens until near expiry ([602d752](602d752)) * Reuse the OIDC JWKS client across requests ([#6683](#6683)) ([a1e6fc2](a1e6fc2)) * Separate CronJob and feature-server ServiceAccounts ([398f643](398f643)) * Serialize UnixTimestamp proto values as raw int64 in remote online store transport ([1e7134f](1e7134f)) * Set FIPS cipher suites before pyarrow.flight import to prevent crash on IBM Power ([979b82a](979b82a)) * Support Entra ID (Azure AD) token claims in OIDC auth ([#6631](#6631)) ([f843c63](f843c63)) * UDF/ODFV source rehydrate (+ Postgres / online cache) ([#6655](#6655)) ([5fd7af7](5fd7af7)) * Updated projects-list.json in order to display newly added projects ([#6657](#6657)) ([3a6a103](3a6a103)) * Use correct image name in multi-arch imagetools push step ([faf85e0](faf85e0)) * Use join keys instead of entity names in ODFV materialization ([#6645](#6645)) ([abffebc](abffebc)), closes [#5965](#5965) * use matching proto class per feature view list in SqliteOnlineStore.plan() ([adb8c1c](adb8c1c)), closes [#6658](#6658) * Widen Athena integer type mapping for unsigned ints ([3425783](3425783)) ### Features * Add ConnectionRef to DataSource for pluggable external credential resolution ([28bde01](28bde01)) * Add Feature Service Create in UI ([0399380](0399380)) * Add hybrid to ValidOfflineStoreDBStorePersistenceTypes for HybridOfflineStore support ([#6707](#6707)) ([310ab51](310ab51)), closes [#6701](#6701) * Add MLflow integration support to Feast operator ([#6611](#6611)) ([52999f1](52999f1)) * Add opt-in filter_by_created_timestamp cutoff to get_historical_features ([#6617](#6617)) ([79b33ce](79b33ce)), closes [#6615](#6615) * Add optional OIDC token audience and issuer verification ([#6670](#6670)) ([ef307c6](ef307c6)) * Add packaged feature repository support to Feast Operator ([8112b1e](8112b1e)), closes [#6598](#6598) * add plan() support to DynamoDBOnlineStore ([51ce982](51ce982)), closes [#6658](#6658) [#6659](#6659) * Added optional namespace/colleciton to datasets ([165fcf2](165fcf2)) * Added SQL registry schema_mode and registry create command ([#6704](#6704)) ([037c4cd](037c4cd)) * Allow users to have protected project on shared registry ([f9923bc](f9923bc)) * Apply Intermediate TLS defaults on API fallback and handle transient errors ([#6587](#6587)) ([43ae993](43ae993)) * **cli:** Updated feast init demo by adding rag template ([#5946](#5946)) ([c8628eb](c8628eb)), closes [#5264](#5264) * Expose the OIDC JWKS tunables through the operator ([#6690](#6690)) ([fef4e78](fef4e78)), closes [#6683](#6683) * Making feast vector store with open ai search api compatible ([#6121](#6121)) ([54da19a](54da19a)) * Multi-arch publish for feast operator image ([b221036](b221036)) * OpenLineage lineage enhancements - full object coverage, richer UI, and API-level sync ([#6719](#6719)) ([120a868](120a868)) * **operator:** Add spec.services.initImage for init container image override ([#6598](#6598)) ([ca355cb](ca355cb)) * Pass optional OIDC audience and issuer through the operator ([#6677](#6677)) ([a13ed7b](a13ed7b)), closes [#6670](#6670) * **server:** Remote Materialization ([#6649](#6649)) ([b7ae488](b7ae488)), closes [#4526](#4526) * Support Lineage configs via operator ([bf1e54a](bf1e54a)) * Updated datasets UI to support grouping ([7ae64ec](7ae64ec))

$@nithin42$

nithin42 requested a review from a team as a code owner August 7, 2026 19:06

This was referenced Aug 7, 2026

fix: Add DynamoDB connection pre-warming, fix mypy TorchTensor type alias, and fix CI mcp pin mismatch #6710

Closed

torch tensor type error with mypy #5563

Closed

$jyejare$

jyejare approved these changes Aug 10, 2026

View reviewed changes

$@jyejare$ jyejare added the ok-to-test label Aug 10, 2026

$@nithin42$

nithin42 requested a review from jyejare August 10, 2026 11:30

$@nithin42$

nithin42 force-pushed the fix/online-response-mypy branch from 6765bd1 to 0cbce28 Compare August 10, 2026 11:33

$@nithin42$

nithin42 force-pushed the fix/online-response-mypy branch from 0cbce28 to a0c040f Compare August 10, 2026 11:34

$jyejare$

jyejare approved these changes Aug 10, 2026

View reviewed changes

$@jyejare$

jyejare merged commit 34de6fa into feast-dev:master Aug 10, 2026
23 checks passed

Navigation Menu

Uh oh!

fix: Fix mypy TorchTensor type alias error - #6712

fix: Fix mypy TorchTensor type alias error#6712
jyejare merged 2 commits into
feast-dev:masterfrom
nithin42:fix/online-response-mypy

$@nithin42$ nithin42 commented Aug 7, 2026

Uh oh!

$@jyejare$ jyejare left a comment

Uh oh!

$@jyejare$ jyejare Aug 10, 2026

Uh oh!

nithin42 commented Aug 10, 2026

Uh oh!

nithin42 commented Aug 10, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Aug 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nithin42 commented Aug 7, 2026

What this PR does / why we need it

Which issue(s) this PR fixes

Checks

Uh oh!

jyejare left a comment

Choose a reason for hiding this comment

Uh oh!

jyejare Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

nithin42 commented Aug 10, 2026

Uh oh!

nithin42 commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

$@nithin42$ nithin42 commented Aug 7, 2026

$@jyejare$ jyejare left a comment

$@jyejare$ jyejare Aug 10, 2026

nithin42 commented Aug 10, 2026 •

edited

Loading

codecov-commenter commented Aug 10, 2026 •

edited

Loading