fix: Normalize SQL registry read_path to the psycopg3 driver like path - #6644
Merged
ntkathole merged 3 commits intoJul 30, 2026
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6644 +/- ##
=======================================
Coverage 46.43% 46.44%
=======================================
Files 414 414
Lines 50125 50134 +9
Branches 7172 7173 +1
=======================================
+ Hits 23275 23284 +9
+ Misses 25213 25212 -1
- Partials 1637 1638 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Author
|
@ntkathole could you take a look at this one too? It never picked up a reviewer assignment, so it's been sitting since the 24th. Checks are green and there are no open review threads. |
ntkathole
force-pushed
the
fix/sql-registry-read-path-normalization
branch
from
July 29, 2026 03:37
0f9ae03 to
983cd2a
Compare
ntkathole
force-pushed
the
fix/sql-registry-read-path-normalization
branch
from
July 30, 2026 05:25
983cd2a to
9397022
Compare
ntkathole
reviewed
Jul 30, 2026
ntkathole
reviewed
Jul 30, 2026
RegistryConfig.validate_path rewrites a bare postgresql:// path to postgresql+psycopg:// (psycopg3) and warns, but SqlRegistryConfig.read_path had no equivalent validator, so a bare postgresql:// read_path reached create_engine unchanged and silently used psycopg2 while path used psycopg3. Factor the rewrite+warning into a shared RegistryConfig._normalize_postgres_scheme static helper and add a field_validator on read_path that mirrors validate_path. The helper rewrites only the leading scheme (not later occurrences) and the path warning text is unchanged. Add unit tests: read_path normalized (explicit and defaulted registry_type), explicit +psycopg2/+psycopg and non-postgres schemes left untouched, None stays None, and the migration warning is emitted. Fixes feast-dev#6643 Signed-off-by: Larry Singleton <166439969+larrysingleton007@users.noreply.github.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Drop the registry_type == "sql" condition from validate_read_path: SqlRegistryConfig is only ever used for SQL registries, so the check was redundant (and the now-unused ValidationInfo parameter and import go with it). Also fix the 'explicitely' typo in the normalization warning message. Signed-off-by: Larry Singleton <166439969+larrysingleton007@users.noreply.github.com>
ntkathole
force-pushed
the
fix/sql-registry-read-path-normalization
branch
from
July 30, 2026 12:17
fe6ce6c to
e08fa87
Compare
ntkathole
approved these changes
Jul 30, 2026
jyejare
pushed a commit
to opendatahub-io/feast
that referenced
this pull request
Aug 5, 2026
feast-dev#6644) * fix: Normalize SQL registry read_path to the psycopg3 driver like path RegistryConfig.validate_path rewrites a bare postgresql:// path to postgresql+psycopg:// (psycopg3) and warns, but SqlRegistryConfig.read_path had no equivalent validator, so a bare postgresql:// read_path reached create_engine unchanged and silently used psycopg2 while path used psycopg3. Factor the rewrite+warning into a shared RegistryConfig._normalize_postgres_scheme static helper and add a field_validator on read_path that mirrors validate_path. The helper rewrites only the leading scheme (not later occurrences) and the path warning text is unchanged. Add unit tests: read_path normalized (explicit and defaulted registry_type), explicit +psycopg2/+psycopg and non-postgres schemes left untouched, None stays None, and the migration warning is emitted. Fixes feast-dev#6643 Signed-off-by: Larry Singleton <166439969+larrysingleton007@users.noreply.github.com> * test: Cover prefix-only PostgreSQL scheme normalization Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * fix: Address review feedback on read_path validator Drop the registry_type == "sql" condition from validate_read_path: SqlRegistryConfig is only ever used for SQL registries, so the check was redundant (and the now-unused ValidationInfo parameter and import go with it). Also fix the 'explicitely' typo in the normalization warning message. Signed-off-by: Larry Singleton <166439969+larrysingleton007@users.noreply.github.com> --------- Signed-off-by: Larry Singleton <166439969+larrysingleton007@users.noreply.github.com> Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> Co-authored-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
pushed a commit
that referenced
this pull request
Aug 21, 2026
# [0.66.0](v0.65.0...v0.66.0) (2026-08-21) ### Bug Fixes * Add connection pre-warming for DynamoDB async client ([89240fa](89240fa)), closes [#6060](#6060) * Add remote registry client extra ([#6697](#6697)) ([b8dfcb0](b8dfcb0)) * Address review feedback on FIPS cipher suite configuration ([4a35fba](4a35fba)) * Allow remote-registry first apply for new projects ([39d408d](39d408d)) * Avoid importing feast.feature_store at mcp_server import time ([ddb2e9a](ddb2e9a)) * Bump pymssql to >=2.3.6 for macOS arm64 wheel support ([181eb35](181eb35)), closes [#5636](#5636) [#5193](#5193) [#5636](#5636) * Call ApplySavedDataset RPC instead of ApplyFeatureService in RemoteRegistry.apply_saved_dataset() ([934d341](934d341)) * Catch missing dbt parser dependency in dbt CLI commands ([#6534](#6534)) ([3c2ae3c](3c2ae3c)) * Default authentication to kubernetes auth ([6a4690a](6a4690a)) * Defer feature-freshness thread to post-fork to avoid Gunicorn deadlock ([#6648](#6648)) ([104ad10](104ad10)), closes [#6647](#6647) * Do not pass undeclared feature view columns to ODFV UDFs ([#6527](#6527)) ([75b9463](75b9463)) * downgrade mcp pin to 1.29.0 and fix CI lockfiles and unit tests ([98e5bca](98e5bca)), closes [#6706](#6706) * Feast apply silently ignoring ttl updates to None or timedelta(0) ([#6709](#6709)) ([97b0f25](97b0f25)), closes [#6703](#6703) * Fix mypy TorchTensor type alias error ([#6712](#6712)) ([34de6fa](34de6fa)), closes [#5563](#5563) * Fixed data source creation form gaps ([5d0f7d6](5d0f7d6)) * Handle parameterized and complex Trino types in type map ([326554d](326554d)) * Isolate default user permissions ([e37adbf](e37adbf)) * Isolate projection join key maps ([d1c709d](d1c709d)) * Map Postgres real to FLOAT instead of DOUBLE ([62db435](62db435)) * Merge shared ODFV source projections in feature resolution ([d269946](d269946)), closes [#6621](#6621) * More exhaustive athena types ([a9aaefc](a9aaefc)) * Normalize SQL registry read_path to the psycopg3 driver like path ([#6644](#6644)) ([996c6ea](996c6ea)), closes [#6643](#6643) * **operator:** add spec.services.onlineStore.disabled to opt out of the online store ([d81d4e3](d81d4e3)), closes [#6586](#6586) * Preinstall DuckDB delta extension for tests ([fd4d49d](fd4d49d)), closes [#6743](#6743) * Preserve event-time ordering within Redis online_write_batch ([40fb788](40fb788)), closes [#5163](#5163) * Prevent mutation of cached feature resolution results ([ea17419](ea17419)) * Remote feastRef FeatureStore fails first apply for a new feastProject ([9affee5](9affee5)) * Remove inert subjectaccessreviews and reorganize RBAC rules ([f771ea4](f771ea4)) * Report single-feature-view spark_application materialization success ([a9219d9](a9219d9)), closes [#6673](#6673) * Reset the global security manager after the permissions fixture ([7667215](7667215)) * Resolve kserve with pip --dry-run instead of installing it ([01da132](01da132)), closes [#6732](#6732) * Resolve write_to_offline_store feature view with a single registry lookup ([a42dc85](a42dc85)), closes [#4235](#4235) * Return False from __eq__ on cross-type comparison ([#6637](#6637)) ([0f149a9](0f149a9)), closes [#6636](#6636) * Reuse IdP-issued client tokens until near expiry ([602d752](602d752)) * Reuse the OIDC JWKS client across requests ([#6683](#6683)) ([a1e6fc2](a1e6fc2)) * Separate CronJob and feature-server ServiceAccounts ([398f643](398f643)) * Serialize UnixTimestamp proto values as raw int64 in remote online store transport ([1e7134f](1e7134f)) * Set FIPS cipher suites before pyarrow.flight import to prevent crash on IBM Power ([979b82a](979b82a)) * Support Entra ID (Azure AD) token claims in OIDC auth ([#6631](#6631)) ([f843c63](f843c63)) * UDF/ODFV source rehydrate (+ Postgres / online cache) ([#6655](#6655)) ([5fd7af7](5fd7af7)) * Updated projects-list.json in order to display newly added projects ([#6657](#6657)) ([3a6a103](3a6a103)) * Use correct image name in multi-arch imagetools push step ([faf85e0](faf85e0)) * Use join keys instead of entity names in ODFV materialization ([#6645](#6645)) ([abffebc](abffebc)), closes [#5965](#5965) * use matching proto class per feature view list in SqliteOnlineStore.plan() ([adb8c1c](adb8c1c)), closes [#6658](#6658) * Widen Athena integer type mapping for unsigned ints ([3425783](3425783)) ### Features * Add ConnectionRef to DataSource for pluggable external credential resolution ([28bde01](28bde01)) * Add Feature Service Create in UI ([0399380](0399380)) * Add hybrid to ValidOfflineStoreDBStorePersistenceTypes for HybridOfflineStore support ([#6707](#6707)) ([310ab51](310ab51)), closes [#6701](#6701) * Add MLflow integration support to Feast operator ([#6611](#6611)) ([52999f1](52999f1)) * Add opt-in filter_by_created_timestamp cutoff to get_historical_features ([#6617](#6617)) ([79b33ce](79b33ce)), closes [#6615](#6615) * Add optional OIDC token audience and issuer verification ([#6670](#6670)) ([ef307c6](ef307c6)) * Add packaged feature repository support to Feast Operator ([8112b1e](8112b1e)), closes [#6598](#6598) * add plan() support to DynamoDBOnlineStore ([51ce982](51ce982)), closes [#6658](#6658) [#6659](#6659) * Added optional namespace/colleciton to datasets ([165fcf2](165fcf2)) * Added SQL registry schema_mode and registry create command ([#6704](#6704)) ([037c4cd](037c4cd)) * Allow users to have protected project on shared registry ([f9923bc](f9923bc)) * Apply Intermediate TLS defaults on API fallback and handle transient errors ([#6587](#6587)) ([43ae993](43ae993)) * **cli:** Updated feast init demo by adding rag template ([#5946](#5946)) ([c8628eb](c8628eb)), closes [#5264](#5264) * Expose the OIDC JWKS tunables through the operator ([#6690](#6690)) ([fef4e78](fef4e78)), closes [#6683](#6683) * Making feast vector store with open ai search api compatible ([#6121](#6121)) ([54da19a](54da19a)) * Multi-arch publish for feast operator image ([b221036](b221036)) * OpenLineage lineage enhancements - full object coverage, richer UI, and API-level sync ([#6719](#6719)) ([120a868](120a868)) * **operator:** Add spec.services.initImage for init container image override ([#6598](#6598)) ([ca355cb](ca355cb)) * Pass optional OIDC audience and issuer through the operator ([#6677](#6677)) ([a13ed7b](a13ed7b)), closes [#6670](#6670) * **server:** Remote Materialization ([#6649](#6649)) ([b7ae488](b7ae488)), closes [#4526](#4526) * Support Lineage configs via operator ([bf1e54a](bf1e54a)) * Updated datasets UI to support grouping ([7ae64ec](7ae64ec))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For a SQL registry,
RegistryConfig.validate_pathrewrites a barepostgresql://URL inpathtopostgresql+psycopg://(so SQLAlchemy uses the psycopg3 driver) and logs a warning.read_pathhad no equivalent validator, so a barepostgresql://read_path reachedcreate_engineunchanged and SQLAlchemy fell back to the psycopg2 driver, diverging frompath(which used psycopg3) with no warning.This factors the rewrite and warning into a shared
RegistryConfig._normalize_postgres_schemestatic helper and adds a@field_validator("read_path")onSqlRegistryConfigthat mirrorsvalidate_path. Thepathwarning text is unchanged. The helper now rewrites only the leading scheme rather than every occurrence, so apostgresql://appearing later in the URL is left alone.Which issue(s) this PR fixes:
Fixes #6643
Checks
git commit -s)Testing Strategy
Added
test_sql_registry.pycases: a barepostgresql://read_path is rewritten topostgresql+psycopg://(both with an explicitregistry_type="sql"and with it left to default), an explicitpostgresql+psycopg2/postgresql+psycopgscheme and a non-postgres scheme are left untouched,NonestaysNone, and the migration warning is emitted for read_path. Full unit suite passes locally.Misc
Release note: A bare
postgresql://read_pathon a SQL registry is now rewritten to the psycopg3 driver (postgresql+psycopg://) with a warning, the same waypathalready is, instead of silently falling back to psycopg2.As an outside contributor I can't apply labels, so a maintainer will need to add a
kind/buglabel and runok-to-test.