feat: Implemented registry refresh action feature - #6657
Conversation
franciscojavierarceo
left a comment
There was a problem hiding this comment.
Moving projects-list.json behind a route avoids freezing the response at startup, but _build_projects_list() still calls list_projects(allow_cache=True). With the default registry cache TTL of 600 seconds, a newly added project can remain absent for up to ten minutes—the exact startup-empty case this is intended to fix. Please consider an uncached read (or explicit refresh) for this low-frequency UI endpoint and add the regression test described in the PR body; the current diff changes only ui_server.py and contains no test update.
|
@franciscojavierarceo - Updated _build_projects_list to use allow_cache=False so new projects are visible immediately. Also added the regression test (test_projects_list_dynamic_refresh) and updated the existing tests to hit the dynamic endpoint via TestClient instead of reading the static file from disk. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6657 +/- ##
==========================================
+ Coverage 46.45% 46.75% +0.29%
==========================================
Files 414 414
Lines 50136 50186 +50
Branches 7173 7180 +7
==========================================
+ Hits 23293 23466 +173
+ Misses 25204 25079 -125
- Partials 1639 1641 +2
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
@AdityaPatil22 This turns every browser refresh into a full database round-trip, completely bypassing the caching layer that Feast deliberately built. The fix should keep I think we can :
|
767f7f8 to
aa3e43a
Compare
|
@ntkathole - I have added a refresh button in the UI which lets the users invalidate the cache on demand. Please let me know if there needs to be any change in the UI for the button.
|
35cdf51 to
43193f2
Compare
43193f2 to
964b02c
Compare
| with ui_dir.joinpath("projects-list.json").open(mode="w") as f: | ||
| f.write(json.dumps(projects_dict)) | ||
|
|
||
| @app.get("/projects-list.json") |
There was a problem hiding this comment.
The dynamic route is needed for the Refresh button workflow to work correctly.
When a user clicks Refresh:
POST /api/v1/registry/refresh → invalidates the registry cache
GET /projects-list.json → needs to return the updated project list
If we keep only the static file (written once at startup), the Refresh button would invalidate the cache but /projects-list.json would still serve stale data, new projects wouldn't appear in the project selector until the server is restarted.
There was a problem hiding this comment.
so, now instead of writing static file which is not being used, can the static file write be removed and all subsequent code be moved inside the with block ?
There was a problem hiding this comment.
Removed the static file write and moved all subsequent code inside the with block.
|
Also, please add unit test for the rest api added |
964b02c to
c1ba261
Compare
Signed-off-by: Aditya Patil <adpatil@redhat.com>
Signed-off-by: Aditya Patil <adpatil@redhat.com>
Signed-off-by: Aditya Patil <adpatil@redhat.com>
Signed-off-by: Aditya Patil <adpatil@redhat.com>
Signed-off-by: Aditya Patil <adpatil@redhat.com>
Signed-off-by: Aditya Patil <adpatil@redhat.com>
Signed-off-by: Aditya Patil <adpatil@redhat.com>
ebc9de3 to
6e87a22
Compare
|
Overall looks good now, pending 1 comment and unit tests failures |
…ile at startup Signed-off-by: Aditya Patil <adpatil@redhat.com>
# [0.66.0](v0.65.0...v0.66.0) (2026-08-21) ### Bug Fixes * Add connection pre-warming for DynamoDB async client ([89240fa](89240fa)), closes [#6060](#6060) * Add remote registry client extra ([#6697](#6697)) ([b8dfcb0](b8dfcb0)) * Address review feedback on FIPS cipher suite configuration ([4a35fba](4a35fba)) * Allow remote-registry first apply for new projects ([39d408d](39d408d)) * Avoid importing feast.feature_store at mcp_server import time ([ddb2e9a](ddb2e9a)) * Bump pymssql to >=2.3.6 for macOS arm64 wheel support ([181eb35](181eb35)), closes [#5636](#5636) [#5193](#5193) [#5636](#5636) * Call ApplySavedDataset RPC instead of ApplyFeatureService in RemoteRegistry.apply_saved_dataset() ([934d341](934d341)) * Catch missing dbt parser dependency in dbt CLI commands ([#6534](#6534)) ([3c2ae3c](3c2ae3c)) * Default authentication to kubernetes auth ([6a4690a](6a4690a)) * Defer feature-freshness thread to post-fork to avoid Gunicorn deadlock ([#6648](#6648)) ([104ad10](104ad10)), closes [#6647](#6647) * Do not pass undeclared feature view columns to ODFV UDFs ([#6527](#6527)) ([75b9463](75b9463)) * downgrade mcp pin to 1.29.0 and fix CI lockfiles and unit tests ([98e5bca](98e5bca)), closes [#6706](#6706) * Feast apply silently ignoring ttl updates to None or timedelta(0) ([#6709](#6709)) ([97b0f25](97b0f25)), closes [#6703](#6703) * Fix mypy TorchTensor type alias error ([#6712](#6712)) ([34de6fa](34de6fa)), closes [#5563](#5563) * Fixed data source creation form gaps ([5d0f7d6](5d0f7d6)) * Handle parameterized and complex Trino types in type map ([326554d](326554d)) * Isolate default user permissions ([e37adbf](e37adbf)) * Isolate projection join key maps ([d1c709d](d1c709d)) * Map Postgres real to FLOAT instead of DOUBLE ([62db435](62db435)) * Merge shared ODFV source projections in feature resolution ([d269946](d269946)), closes [#6621](#6621) * More exhaustive athena types ([a9aaefc](a9aaefc)) * Normalize SQL registry read_path to the psycopg3 driver like path ([#6644](#6644)) ([996c6ea](996c6ea)), closes [#6643](#6643) * **operator:** add spec.services.onlineStore.disabled to opt out of the online store ([d81d4e3](d81d4e3)), closes [#6586](#6586) * Preinstall DuckDB delta extension for tests ([fd4d49d](fd4d49d)), closes [#6743](#6743) * Preserve event-time ordering within Redis online_write_batch ([40fb788](40fb788)), closes [#5163](#5163) * Prevent mutation of cached feature resolution results ([ea17419](ea17419)) * Remote feastRef FeatureStore fails first apply for a new feastProject ([9affee5](9affee5)) * Remove inert subjectaccessreviews and reorganize RBAC rules ([f771ea4](f771ea4)) * Report single-feature-view spark_application materialization success ([a9219d9](a9219d9)), closes [#6673](#6673) * Reset the global security manager after the permissions fixture ([7667215](7667215)) * Resolve kserve with pip --dry-run instead of installing it ([01da132](01da132)), closes [#6732](#6732) * Resolve write_to_offline_store feature view with a single registry lookup ([a42dc85](a42dc85)), closes [#4235](#4235) * Return False from __eq__ on cross-type comparison ([#6637](#6637)) ([0f149a9](0f149a9)), closes [#6636](#6636) * Reuse IdP-issued client tokens until near expiry ([602d752](602d752)) * Reuse the OIDC JWKS client across requests ([#6683](#6683)) ([a1e6fc2](a1e6fc2)) * Separate CronJob and feature-server ServiceAccounts ([398f643](398f643)) * Serialize UnixTimestamp proto values as raw int64 in remote online store transport ([1e7134f](1e7134f)) * Set FIPS cipher suites before pyarrow.flight import to prevent crash on IBM Power ([979b82a](979b82a)) * Support Entra ID (Azure AD) token claims in OIDC auth ([#6631](#6631)) ([f843c63](f843c63)) * UDF/ODFV source rehydrate (+ Postgres / online cache) ([#6655](#6655)) ([5fd7af7](5fd7af7)) * Updated projects-list.json in order to display newly added projects ([#6657](#6657)) ([3a6a103](3a6a103)) * Use correct image name in multi-arch imagetools push step ([faf85e0](faf85e0)) * Use join keys instead of entity names in ODFV materialization ([#6645](#6645)) ([abffebc](abffebc)), closes [#5965](#5965) * use matching proto class per feature view list in SqliteOnlineStore.plan() ([adb8c1c](adb8c1c)), closes [#6658](#6658) * Widen Athena integer type mapping for unsigned ints ([3425783](3425783)) ### Features * Add ConnectionRef to DataSource for pluggable external credential resolution ([28bde01](28bde01)) * Add Feature Service Create in UI ([0399380](0399380)) * Add hybrid to ValidOfflineStoreDBStorePersistenceTypes for HybridOfflineStore support ([#6707](#6707)) ([310ab51](310ab51)), closes [#6701](#6701) * Add MLflow integration support to Feast operator ([#6611](#6611)) ([52999f1](52999f1)) * Add opt-in filter_by_created_timestamp cutoff to get_historical_features ([#6617](#6617)) ([79b33ce](79b33ce)), closes [#6615](#6615) * Add optional OIDC token audience and issuer verification ([#6670](#6670)) ([ef307c6](ef307c6)) * Add packaged feature repository support to Feast Operator ([8112b1e](8112b1e)), closes [#6598](#6598) * add plan() support to DynamoDBOnlineStore ([51ce982](51ce982)), closes [#6658](#6658) [#6659](#6659) * Added optional namespace/colleciton to datasets ([165fcf2](165fcf2)) * Added SQL registry schema_mode and registry create command ([#6704](#6704)) ([037c4cd](037c4cd)) * Allow users to have protected project on shared registry ([f9923bc](f9923bc)) * Apply Intermediate TLS defaults on API fallback and handle transient errors ([#6587](#6587)) ([43ae993](43ae993)) * **cli:** Updated feast init demo by adding rag template ([#5946](#5946)) ([c8628eb](c8628eb)), closes [#5264](#5264) * Expose the OIDC JWKS tunables through the operator ([#6690](#6690)) ([fef4e78](fef4e78)), closes [#6683](#6683) * Making feast vector store with open ai search api compatible ([#6121](#6121)) ([54da19a](54da19a)) * Multi-arch publish for feast operator image ([b221036](b221036)) * OpenLineage lineage enhancements - full object coverage, richer UI, and API-level sync ([#6719](#6719)) ([120a868](120a868)) * **operator:** Add spec.services.initImage for init container image override ([#6598](#6598)) ([ca355cb](ca355cb)) * Pass optional OIDC audience and issuer through the operator ([#6677](#6677)) ([a13ed7b](a13ed7b)), closes [#6670](#6670) * **server:** Remote Materialization ([#6649](#6649)) ([b7ae488](b7ae488)), closes [#4526](#4526) * Support Lineage configs via operator ([bf1e54a](bf1e54a)) * Updated datasets UI to support grouping ([7ae64ec](7ae64ec))

What this PR does / why we need it:
projects-list.jsonwas written as a static file once at server startup and never refreshed. When a user ranfeast applyto create a new project while the UI was running, the new project never appeared in the UI's project list.This PR replaces the static file write with a dynamic FastAPI route (
GET /projects-list.json) that queries the registry on each request, so newly created projects appear immediately on page refresh.Which issue(s) this PR fixes:
Fixes #6650
Checks
git commit -s)Testing Strategy
Misc
Existing
test_projects_list_*tests updated to hit the dynamic endpoint viaTestClientinstead of reading the static file from disk. New testtest_projects_list_dynamic_refreshverifies that mutating the registry afterget_appis reflected in subsequent requests — the core assertion for #6650.