Skip to content

fix: Catch missing dbt parser dependency in dbt CLI commands - #6534

Merged
ntkathole merged 4 commits into
feast-dev:masterfrom
kchawlani19:fix/issue-5870
Jul 30, 2026
Merged

fix: Catch missing dbt parser dependency in dbt CLI commands#6534
ntkathole merged 4 commits into
feast-dev:masterfrom
kchawlani19:fix/issue-5870

Conversation

@kchawlani19

Copy link
Copy Markdown
Contributor

What this PR does

This PR improves error handling in the dbt CLI import flow when the dbt-artifacts-parser dependency is not installed.

Previously, users could encounter an unclear import-related failure. This change catches the missing dependency condition and provides a clearer error path for users.

Changes

  • Improve handling of missing dbt-artifacts-parser imports in the dbt CLI integration.
  • Add integration test coverage for the missing dependency scenario.

Testing

  • Added integration test for missing dependency behavior.
  • Verified existing behavior remains unchanged when the dependency is available.

Related Issue

#5870

@kchawlani19
kchawlani19 requested a review from a team as a code owner June 17, 2026 06:32
@kchawlani19 kchawlani19 changed the title fix(dbt): handle missing dbt-artifacts-parser import errors in CLI fix: catch ImportError in feast dbt import/list commands Jun 17, 2026
@kchawlani19 kchawlani19 changed the title fix: catch ImportError in feast dbt import/list commands fix: Catch missing dbt parser dependency in dbt CLI commands Jun 17, 2026

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix tests thank you

@kchawlani19

Copy link
Copy Markdown
Contributor Author

hello @franciscojavierarceo , can this be reviewed ?

kchawlani19 and others added 4 commits July 30, 2026 14:32
Catch ImportError in `feast dbt import` and `feast dbt list` so missing dbt parser dependency returns a clean CLI error. Add regression tests to verify both commands exit with actionable install guidance.

Signed-off-by: kchawlani19 <kchawlan@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: kchawlani19 <kchawlan@redhat.com>
Signed-off-by: kchawlani19 <kchawlan@redhat.com>
Signed-off-by: kchawlani19 <kchawlan@redhat.com>
@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.37%. Comparing base (6019bd6) to head (8204d75).

Files with missing lines Patch % Lines
sdk/python/feast/dbt/parser.py 66.66% 3 Missing and 4 partials ⚠️
sdk/python/feast/cli/dbt_import.py 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6534      +/-   ##
==========================================
+ Coverage   46.36%   46.37%   +0.01%     
==========================================
  Files         414      414              
  Lines       50072    50089      +17     
  Branches     7154     7159       +5     
==========================================
+ Hits        23218    23231      +13     
  Misses      25231    25231              
- Partials     1623     1627       +4     
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 47.68% <60.86%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
sdk/python/feast/cli/dbt_import.py 16.43% <0.00%> (+0.33%) ⬆️
sdk/python/feast/dbt/parser.py 73.98% <66.66%> (-1.75%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6019bd6...8204d75. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntkathole
ntkathole merged commit 3c2ae3c into feast-dev:master Jul 30, 2026
25 checks passed
jyejare pushed a commit to opendatahub-io/feast that referenced this pull request Aug 5, 2026
…ev#6534)

* fix(dbt): handle missing dbt-artifacts-parser import errors in CLI

Catch ImportError in `feast dbt import` and `feast dbt list` so missing dbt parser dependency returns a clean CLI error. Add regression tests to verify both commands exit with actionable install guidance.

Signed-off-by: kchawlani19 <kchawlan@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* test(dbt): make import error CLI assertions robust

Signed-off-by: kchawlani19 <kchawlan@redhat.com>

* test(dbt): make CLI error output assertions click-version safe

Signed-off-by: kchawlani19 <kchawlan@redhat.com>

* fix(dbt): tolerate unsupported macro languages in dbt manifests

Signed-off-by: kchawlani19 <kchawlan@redhat.com>

---------

Signed-off-by: kchawlani19 <kchawlan@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
franciscojavierarceo pushed a commit that referenced this pull request Aug 21, 2026
# [0.66.0](v0.65.0...v0.66.0) (2026-08-21)

### Bug Fixes

* Add connection pre-warming for DynamoDB async client ([89240fa](89240fa)), closes [#6060](#6060)
* Add remote registry client extra ([#6697](#6697)) ([b8dfcb0](b8dfcb0))
* Address review feedback on FIPS cipher suite configuration ([4a35fba](4a35fba))
* Allow remote-registry first apply for new projects ([39d408d](39d408d))
* Avoid importing feast.feature_store at mcp_server import time ([ddb2e9a](ddb2e9a))
* Bump pymssql to >=2.3.6 for macOS arm64 wheel support ([181eb35](181eb35)), closes [#5636](#5636) [#5193](#5193) [#5636](#5636)
* Call ApplySavedDataset RPC instead of ApplyFeatureService in RemoteRegistry.apply_saved_dataset() ([934d341](934d341))
* Catch missing dbt parser dependency in dbt CLI commands ([#6534](#6534)) ([3c2ae3c](3c2ae3c))
* Default authentication to kubernetes auth ([6a4690a](6a4690a))
* Defer feature-freshness thread to post-fork to avoid Gunicorn deadlock ([#6648](#6648)) ([104ad10](104ad10)), closes [#6647](#6647)
* Do not pass undeclared feature view columns to ODFV UDFs ([#6527](#6527)) ([75b9463](75b9463))
* downgrade mcp pin to 1.29.0 and fix CI lockfiles and unit tests ([98e5bca](98e5bca)), closes [#6706](#6706)
* Feast apply silently ignoring ttl updates to None or timedelta(0) ([#6709](#6709)) ([97b0f25](97b0f25)), closes [#6703](#6703)
* Fix mypy TorchTensor type alias error ([#6712](#6712)) ([34de6fa](34de6fa)), closes [#5563](#5563)
* Fixed data source creation form gaps ([5d0f7d6](5d0f7d6))
* Handle parameterized and complex Trino types in type map ([326554d](326554d))
* Isolate default user permissions ([e37adbf](e37adbf))
* Isolate projection join key maps ([d1c709d](d1c709d))
* Map Postgres real to FLOAT instead of DOUBLE ([62db435](62db435))
* Merge shared ODFV source projections in feature resolution ([d269946](d269946)), closes [#6621](#6621)
* More exhaustive athena types ([a9aaefc](a9aaefc))
* Normalize SQL registry read_path to the psycopg3 driver like path ([#6644](#6644)) ([996c6ea](996c6ea)), closes [#6643](#6643)
* **operator:** add spec.services.onlineStore.disabled to opt out of the online store ([d81d4e3](d81d4e3)), closes [#6586](#6586)
* Preinstall DuckDB delta extension for tests ([fd4d49d](fd4d49d)), closes [#6743](#6743)
* Preserve event-time ordering within Redis online_write_batch ([40fb788](40fb788)), closes [#5163](#5163)
* Prevent mutation of cached feature resolution results ([ea17419](ea17419))
* Remote feastRef FeatureStore fails first apply for a new feastProject ([9affee5](9affee5))
* Remove inert subjectaccessreviews and reorganize RBAC rules ([f771ea4](f771ea4))
* Report single-feature-view spark_application materialization success ([a9219d9](a9219d9)), closes [#6673](#6673)
* Reset the global security manager after the permissions fixture ([7667215](7667215))
* Resolve kserve with pip --dry-run instead of installing it ([01da132](01da132)), closes [#6732](#6732)
* Resolve write_to_offline_store feature view with a single registry lookup ([a42dc85](a42dc85)), closes [#4235](#4235)
* Return False from __eq__ on cross-type comparison ([#6637](#6637)) ([0f149a9](0f149a9)), closes [#6636](#6636)
* Reuse IdP-issued client tokens until near expiry ([602d752](602d752))
* Reuse the OIDC JWKS client across requests ([#6683](#6683)) ([a1e6fc2](a1e6fc2))
* Separate CronJob and feature-server ServiceAccounts ([398f643](398f643))
* Serialize UnixTimestamp proto values as raw int64 in remote online store transport ([1e7134f](1e7134f))
* Set FIPS cipher suites before pyarrow.flight import to prevent crash on IBM Power ([979b82a](979b82a))
* Support Entra ID (Azure AD) token claims in OIDC auth ([#6631](#6631)) ([f843c63](f843c63))
* UDF/ODFV source rehydrate (+ Postgres / online cache) ([#6655](#6655)) ([5fd7af7](5fd7af7))
* Updated projects-list.json in order to display newly added projects ([#6657](#6657)) ([3a6a103](3a6a103))
* Use correct image name in multi-arch imagetools push step ([faf85e0](faf85e0))
* Use join keys instead of entity names in ODFV materialization ([#6645](#6645)) ([abffebc](abffebc)), closes [#5965](#5965)
* use matching proto class per feature view list in SqliteOnlineStore.plan() ([adb8c1c](adb8c1c)), closes [#6658](#6658)
* Widen Athena integer type mapping for unsigned ints ([3425783](3425783))

### Features

* Add ConnectionRef to DataSource for pluggable external credential resolution ([28bde01](28bde01))
* Add Feature Service Create in UI ([0399380](0399380))
* Add hybrid to ValidOfflineStoreDBStorePersistenceTypes for HybridOfflineStore support ([#6707](#6707)) ([310ab51](310ab51)), closes [#6701](#6701)
* Add MLflow integration support to Feast operator ([#6611](#6611)) ([52999f1](52999f1))
* Add opt-in filter_by_created_timestamp cutoff to get_historical_features ([#6617](#6617)) ([79b33ce](79b33ce)), closes [#6615](#6615)
* Add optional OIDC token audience and issuer verification ([#6670](#6670)) ([ef307c6](ef307c6))
* Add packaged feature repository support to Feast Operator ([8112b1e](8112b1e)), closes [#6598](#6598)
* add plan() support to DynamoDBOnlineStore ([51ce982](51ce982)), closes [#6658](#6658) [#6659](#6659)
* Added optional namespace/colleciton to datasets ([165fcf2](165fcf2))
* Added SQL registry schema_mode and registry create command ([#6704](#6704)) ([037c4cd](037c4cd))
* Allow users to have protected project on shared registry ([f9923bc](f9923bc))
* Apply Intermediate TLS defaults on API fallback and handle transient errors ([#6587](#6587)) ([43ae993](43ae993))
* **cli:** Updated feast init demo by adding rag template ([#5946](#5946)) ([c8628eb](c8628eb)), closes [#5264](#5264)
* Expose the OIDC JWKS tunables through the operator ([#6690](#6690)) ([fef4e78](fef4e78)), closes [#6683](#6683)
* Making feast vector store with open ai search api compatible ([#6121](#6121)) ([54da19a](54da19a))
* Multi-arch publish for feast operator image ([b221036](b221036))
* OpenLineage lineage enhancements - full object coverage, richer UI, and API-level sync ([#6719](#6719)) ([120a868](120a868))
* **operator:** Add spec.services.initImage for init container image override ([#6598](#6598)) ([ca355cb](ca355cb))
* Pass optional OIDC audience and issuer through the operator ([#6677](#6677)) ([a13ed7b](a13ed7b)), closes [#6670](#6670)
* **server:** Remote Materialization ([#6649](#6649)) ([b7ae488](b7ae488)), closes [#4526](#4526)
* Support Lineage configs via operator ([bf1e54a](bf1e54a))
* Updated datasets UI to support grouping ([7ae64ec](7ae64ec))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants