Skip to content

feat: Add MLflow integration support to Feast operator - #6611

Merged
ntkathole merged 11 commits into
feast-dev:masterfrom
Vperiodt:feast-mlflow-rhoai
Aug 18, 2026
Merged

feat: Add MLflow integration support to Feast operator#6611
ntkathole merged 11 commits into
feast-dev:masterfrom
Vperiodt:feast-mlflow-rhoai

Conversation

@Vperiodt

@Vperiodt Vperiodt commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

  • Adds optional spec.mlflow.uiUrl and wires it into feature_store.yaml as ui_url
  • Auto-discovers tracking URI (status.address.url) and UI URL (status.url) from the cluster MLflow CR
  • Feast UI lineage links use MlflowConfig.get_ui_url() (falls back to tracking URI for local/dev)

Which issue(s) this PR fixes:

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc

@codecov-commenter

codecov-commenter commented Jul 17, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.95%. Comparing base (120a868) to head (a0f5ba6).

Files with missing lines Patch % Lines
sdk/python/feast/mlflow_integration/config.py 0.00% 8 Missing ⚠️
sdk/python/feast/ui_server.py 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6611      +/-   ##
==========================================
- Coverage   46.96%   46.95%   -0.01%     
==========================================
  Files         417      417              
  Lines       51385    51393       +8     
  Branches     7437     7438       +1     
==========================================
  Hits        24133    24133              
- Misses      25522    25530       +8     
  Partials     1730     1730              
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.26% <0.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
sdk/python/feast/ui_server.py 24.64% <0.00%> (ø)
sdk/python/feast/mlflow_integration/config.py 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120a868...a0f5ba6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Vperiodt
Vperiodt marked this pull request as ready for review July 21, 2026 11:40
@Vperiodt
Vperiodt requested a review from a team as a code owner July 21, 2026 11:40
needsDiscovery := cr.Spec.Mlflow.TrackingUri == nil || cr.Spec.Mlflow.UiUrl == nil
if needsDiscovery && feast.Handler.Client != nil {
if discovered, ok := DiscoverMlflow(feast.Handler.Context, feast.Handler.Client); ok {
if cr.Status.Applied.Mlflow.TrackingUri == nil {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if cr.Status.Applied.Mlflow.TrackingUri == nil {
if cr.Status.Applied.Mlflow != nil && cr.Status.Applied.Mlflow.TrackingUri == nil {

return condStatus == "True"
}
}
return true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should return false, Returning true here could cause the operator to use a partially-initialized MLflow instance.

return
}
mlflowEnv := []corev1.EnvVar{
{Name: "MLFLOW_TRACKING_AUTH", Value: "kubernetes-namespaced"},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be configurable and not hard-coded

rb.RoleRef = rbacv1.RoleRef{
APIGroup: "rbac.authorization.k8s.io",
Kind: "ClusterRole",
Name: "mlflow-integration",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the MLflow operator provide this role ? I don't see logic to create

EntityDfMaxRows *int32 `yaml:"entity_df_max_rows,omitempty"`
LogOperations *bool `yaml:"log_operations,omitempty"`
OpsExperimentSuffix *string `yaml:"ops_experiment_suffix,omitempty"`
ExtraConfig map[string]interface{} `yaml:",inline,omitempty"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user puts tracking_uri or enabled in ExtraConfig, it would create conflicting/duplicate YAML keys. A kubebuilder validation rule or runtime check should prevent this.

func (r *FeatureStoreReconciler) mapMlflowToFeastRequests(ctx context.Context, _ client.Object) []reconcile.Request {
logger := log.FromContext(ctx)
var feastList feastdevv1.FeatureStoreList
if err := r.List(ctx, &feastList, client.InNamespace("")); err != nil {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider improving client.InNamespace("")); (rate-limiting / debounce strategy) lists FeatureStores across the entire cluster on every MLflow CR change. On large clusters this could produce significant API server load.

@Vperiodt
Vperiodt force-pushed the feast-mlflow-rhoai branch from 880895c to 7774e4c Compare August 4, 2026 09:11
@ntkathole

Copy link
Copy Markdown
Member

@Vperiodt get_mlflow_feature_models is not fixed, still uses tracking_uri

https://github.com/Vperiodt/feast/blob/86691c91b273346f160027d0b9f3bc2e7fbd282e/sdk/python/feast/ui_server.py#L1122

mlflow_ui_base = (
    mlflow_cfg.get_ui_url() or mlflow.get_tracking_uri() or ""
)

@Vperiodt
Vperiodt force-pushed the feast-mlflow-rhoai branch from 81745f4 to b441f95 Compare August 11, 2026 14:46
@ntkathole

Copy link
Copy Markdown
Member

@Vperiodt please fix linting and conflicts

Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Update .secrets.baseline line numbers after MLflow CRD/controller
additions so detect-secrets pre-commit passes in CI.

Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Regenerate .secrets.baseline from master so detect-secrets line numbers
match the MLflow operator changes and CI pre-commit stays stable.

Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Vperiodt
Vperiodt force-pushed the feast-mlflow-rhoai branch from b441f95 to 84b65ed Compare August 14, 2026 08:33
Use mlflow_cfg.get_ui_url() as the base URL for model links in
get_mlflow_feature_models, consistent with get_mlflow_experiments.
Falls back to mlflow.get_tracking_uri() when no explicit UI URL is set.

Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>
@Vperiodt
Vperiodt force-pushed the feast-mlflow-rhoai branch from 84b65ed to 098fcbd Compare August 14, 2026 10:57
@Vperiodt

Copy link
Copy Markdown
Contributor Author

@Vperiodt please fix linting and conflicts

done!

@ntkathole

Copy link
Copy Markdown
Member

@Vperiodt Please add documentation for mlflow in operator docs - docs/how-to-guides/feast-operator/

@ntkathole ntkathole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

@ntkathole

Copy link
Copy Markdown
Member

Please resolve the conflicts as well and add docs, will merge

Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>
@ntkathole
ntkathole merged commit 52999f1 into feast-dev:master Aug 18, 2026
26 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Aug 21, 2026
# [0.66.0](v0.65.0...v0.66.0) (2026-08-21)

### Bug Fixes

* Add connection pre-warming for DynamoDB async client ([89240fa](89240fa)), closes [#6060](#6060)
* Add remote registry client extra ([#6697](#6697)) ([b8dfcb0](b8dfcb0))
* Address review feedback on FIPS cipher suite configuration ([4a35fba](4a35fba))
* Allow remote-registry first apply for new projects ([39d408d](39d408d))
* Avoid importing feast.feature_store at mcp_server import time ([ddb2e9a](ddb2e9a))
* Bump pymssql to >=2.3.6 for macOS arm64 wheel support ([181eb35](181eb35)), closes [#5636](#5636) [#5193](#5193) [#5636](#5636)
* Call ApplySavedDataset RPC instead of ApplyFeatureService in RemoteRegistry.apply_saved_dataset() ([934d341](934d341))
* Catch missing dbt parser dependency in dbt CLI commands ([#6534](#6534)) ([3c2ae3c](3c2ae3c))
* Default authentication to kubernetes auth ([6a4690a](6a4690a))
* Defer feature-freshness thread to post-fork to avoid Gunicorn deadlock ([#6648](#6648)) ([104ad10](104ad10)), closes [#6647](#6647)
* Do not pass undeclared feature view columns to ODFV UDFs ([#6527](#6527)) ([75b9463](75b9463))
* downgrade mcp pin to 1.29.0 and fix CI lockfiles and unit tests ([98e5bca](98e5bca)), closes [#6706](#6706)
* Feast apply silently ignoring ttl updates to None or timedelta(0) ([#6709](#6709)) ([97b0f25](97b0f25)), closes [#6703](#6703)
* Fix mypy TorchTensor type alias error ([#6712](#6712)) ([34de6fa](34de6fa)), closes [#5563](#5563)
* Fixed data source creation form gaps ([5d0f7d6](5d0f7d6))
* Handle parameterized and complex Trino types in type map ([326554d](326554d))
* Isolate default user permissions ([e37adbf](e37adbf))
* Isolate projection join key maps ([d1c709d](d1c709d))
* Map Postgres real to FLOAT instead of DOUBLE ([62db435](62db435))
* Merge shared ODFV source projections in feature resolution ([d269946](d269946)), closes [#6621](#6621)
* More exhaustive athena types ([a9aaefc](a9aaefc))
* Normalize SQL registry read_path to the psycopg3 driver like path ([#6644](#6644)) ([996c6ea](996c6ea)), closes [#6643](#6643)
* **operator:** add spec.services.onlineStore.disabled to opt out of the online store ([d81d4e3](d81d4e3)), closes [#6586](#6586)
* Preinstall DuckDB delta extension for tests ([fd4d49d](fd4d49d)), closes [#6743](#6743)
* Preserve event-time ordering within Redis online_write_batch ([40fb788](40fb788)), closes [#5163](#5163)
* Prevent mutation of cached feature resolution results ([ea17419](ea17419))
* Remote feastRef FeatureStore fails first apply for a new feastProject ([9affee5](9affee5))
* Remove inert subjectaccessreviews and reorganize RBAC rules ([f771ea4](f771ea4))
* Report single-feature-view spark_application materialization success ([a9219d9](a9219d9)), closes [#6673](#6673)
* Reset the global security manager after the permissions fixture ([7667215](7667215))
* Resolve kserve with pip --dry-run instead of installing it ([01da132](01da132)), closes [#6732](#6732)
* Resolve write_to_offline_store feature view with a single registry lookup ([a42dc85](a42dc85)), closes [#4235](#4235)
* Return False from __eq__ on cross-type comparison ([#6637](#6637)) ([0f149a9](0f149a9)), closes [#6636](#6636)
* Reuse IdP-issued client tokens until near expiry ([602d752](602d752))
* Reuse the OIDC JWKS client across requests ([#6683](#6683)) ([a1e6fc2](a1e6fc2))
* Separate CronJob and feature-server ServiceAccounts ([398f643](398f643))
* Serialize UnixTimestamp proto values as raw int64 in remote online store transport ([1e7134f](1e7134f))
* Set FIPS cipher suites before pyarrow.flight import to prevent crash on IBM Power ([979b82a](979b82a))
* Support Entra ID (Azure AD) token claims in OIDC auth ([#6631](#6631)) ([f843c63](f843c63))
* UDF/ODFV source rehydrate (+ Postgres / online cache) ([#6655](#6655)) ([5fd7af7](5fd7af7))
* Updated projects-list.json in order to display newly added projects ([#6657](#6657)) ([3a6a103](3a6a103))
* Use correct image name in multi-arch imagetools push step ([faf85e0](faf85e0))
* Use join keys instead of entity names in ODFV materialization ([#6645](#6645)) ([abffebc](abffebc)), closes [#5965](#5965)
* use matching proto class per feature view list in SqliteOnlineStore.plan() ([adb8c1c](adb8c1c)), closes [#6658](#6658)
* Widen Athena integer type mapping for unsigned ints ([3425783](3425783))

### Features

* Add ConnectionRef to DataSource for pluggable external credential resolution ([28bde01](28bde01))
* Add Feature Service Create in UI ([0399380](0399380))
* Add hybrid to ValidOfflineStoreDBStorePersistenceTypes for HybridOfflineStore support ([#6707](#6707)) ([310ab51](310ab51)), closes [#6701](#6701)
* Add MLflow integration support to Feast operator ([#6611](#6611)) ([52999f1](52999f1))
* Add opt-in filter_by_created_timestamp cutoff to get_historical_features ([#6617](#6617)) ([79b33ce](79b33ce)), closes [#6615](#6615)
* Add optional OIDC token audience and issuer verification ([#6670](#6670)) ([ef307c6](ef307c6))
* Add packaged feature repository support to Feast Operator ([8112b1e](8112b1e)), closes [#6598](#6598)
* add plan() support to DynamoDBOnlineStore ([51ce982](51ce982)), closes [#6658](#6658) [#6659](#6659)
* Added optional namespace/colleciton to datasets ([165fcf2](165fcf2))
* Added SQL registry schema_mode and registry create command ([#6704](#6704)) ([037c4cd](037c4cd))
* Allow users to have protected project on shared registry ([f9923bc](f9923bc))
* Apply Intermediate TLS defaults on API fallback and handle transient errors ([#6587](#6587)) ([43ae993](43ae993))
* **cli:** Updated feast init demo by adding rag template ([#5946](#5946)) ([c8628eb](c8628eb)), closes [#5264](#5264)
* Expose the OIDC JWKS tunables through the operator ([#6690](#6690)) ([fef4e78](fef4e78)), closes [#6683](#6683)
* Making feast vector store with open ai search api compatible ([#6121](#6121)) ([54da19a](54da19a))
* Multi-arch publish for feast operator image ([b221036](b221036))
* OpenLineage lineage enhancements - full object coverage, richer UI, and API-level sync ([#6719](#6719)) ([120a868](120a868))
* **operator:** Add spec.services.initImage for init container image override ([#6598](#6598)) ([ca355cb](ca355cb))
* Pass optional OIDC audience and issuer through the operator ([#6677](#6677)) ([a13ed7b](a13ed7b)), closes [#6670](#6670)
* **server:** Remote Materialization ([#6649](#6649)) ([b7ae488](b7ae488)), closes [#4526](#4526)
* Support Lineage configs via operator ([bf1e54a](bf1e54a))
* Updated datasets UI to support grouping ([7ae64ec](7ae64ec))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants