Skip to content

fix: Use matching proto class per feature view list in SqliteOnlineStore.plan() - #6659

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
casaar97:fix/plan-stream-feature-view-typecheck
Jul 30, 2026
Merged

fix: Use matching proto class per feature view list in SqliteOnlineStore.plan()#6659
ntkathole merged 1 commit into
feast-dev:masterfrom
casaar97:fix/plan-stream-feature-view-typecheck

Conversation

@casaar97

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Fixes #6658.

SqliteOnlineStore.plan() applies FeatureView.from_proto() uniformly to both desired_registry_proto.feature_views and desired_registry_proto.stream_feature_views. FeatureView is @typechecked, and from_proto's parameter is annotated as FeatureViewProto, so passing a StreamFeatureViewProto (from the stream_feature_views list) raises typeguard.TypeCheckError at runtime -- plan() (and therefore feast plan) fails outright on any repo with at least one StreamFeatureView registered.

This uses the matching class per list instead:

views = [
    FeatureView.from_proto(view) for view in desired_registry_proto.feature_views
] + [
    StreamFeatureView.from_proto(view)
    for view in desired_registry_proto.stream_feature_views
]

_table_id() / compute_table_id() / compute_versioned_name() only touch .name, .projection, and .current_version_number (the latter two via getattr with defaults), so a StreamFeatureView instance works the same as a FeatureView instance there -- no other change needed.

We ran into this adding plan()/InfraObject support to a custom online store and initially copied this exact pattern from sqlite.py as the only in-tree reference implementation of plan().

Which issue(s) this PR fixes

Fixes #6658

Does this PR introduce a user-facing change?

Fixed `feast plan` raising a typeguard.TypeCheckError for any repo with a registered StreamFeatureView.

Test plan

  • Added sdk/python/tests/unit/infra/online_store/test_sqlite_plan.py with two cases: a registry with only a StreamFeatureView, and one with a batch FeatureView and a StreamFeatureView together.
  • Confirmed both fail with the exact traceback from sqlite.py's OnlineStore.plan() raises typeguard.TypeCheckError for stream feature views #6658 on master before this change, and pass after.
  • Ran the full sdk/python/tests/unit/infra/online_store/ directory (206 tests) -- no regressions.
  • ruff check and ruff format --check pass on the changed files.

@casaar97
casaar97 requested a review from a team as a code owner July 29, 2026 12:28
@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.99%. Comparing base (51ce982) to head (d972891).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6659      +/-   ##
==========================================
+ Coverage   45.93%   45.99%   +0.05%     
==========================================
  Files         414      414              
  Lines       50006    50037      +31     
  Branches     7147     7147              
==========================================
+ Hits        22972    23014      +42     
+ Misses      25423    25412      -11     
  Partials     1611     1611              
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 47.26% <100.00%> (+0.05%) ⬆️
Files with missing lines Coverage Δ
sdk/python/feast/infra/online_stores/sqlite.py 60.04% <100.00%> (+1.41%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51ce982...d972891. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@casaar97
casaar97 force-pushed the fix/plan-stream-feature-view-typecheck branch from 02e0617 to 47550c8 Compare July 29, 2026 12:34
@casaar97 casaar97 changed the title fix: use matching proto class per feature view list in SqliteOnlineStore.plan() fix: Use matching proto class per feature view list in SqliteOnlineStore.plan() Jul 29, 2026
@casaar97
casaar97 force-pushed the fix/plan-stream-feature-view-typecheck branch from 47550c8 to 86cf676 Compare July 29, 2026 12:35
@casaar97

Copy link
Copy Markdown
Contributor Author

The `unit-test-go` failure looks unrelated to this change (only Python files are touched here): `open .../go/internal/test/feature_repo/data/registry.db: no such file or directory` in `TestNewFeatureStore`. That same job passed on the base commit this branch is built from (104ad10), so it looks like environmental flakiness in that job rather than something introduced by this PR. Happy to look further if it's actually related -- let me know.

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the matching class for each proto list fixes the typeguard failure while preserving the table-ID path, and the new tests cover stream-only and mixed registries. I found no blocking issue in the remote diff.

ntkathole pushed a commit that referenced this pull request Jul 30, 2026
DynamoDBOnlineStore has no plan() override, so it inherits
OnlineStore.plan()'s no-op default: `feast plan` never reports any
DynamoDB infrastructure changes, unlike SqliteOnlineStore and
MilvusOnlineStore which both implement it.

Adds DynamoDBTable (InfraObject) and DynamoDBOnlineStore.plan(), using
the InfraObject proto's CustomInfra field (protos/feast/core/InfraObject.proto),
which exists specifically so online stores can add InfraObject support
without changes to the core proto -- no other in-tree store uses it yet.

Note this only affects `feast plan`'s reporting: `feast apply`'s
diff-based path (FeatureStore._should_use_plan(), which would call
InfraObject.update()/teardown()) is gated to the local/sqlite provider
only, so DynamoDBOnlineStore.update()/teardown() -- which already
perform the real table creation/deletion -- are unaffected.

Uses the corrected feature-view-list pattern (see #6658 / #6659):
FeatureView.from_proto() and StreamFeatureView.from_proto() applied to
their respective proto lists, not one applied to both.

Signed-off-by: Carlos Sánchez <carlos.sancheza@cabify.com>
…ore.plan()

FeatureView.from_proto() was applied uniformly to both feature_views and
stream_feature_views. FeatureView is @TypeChecked and its from_proto()
parameter is annotated as FeatureViewProto, so passing a
StreamFeatureViewProto raises typeguard.TypeCheckError at runtime.

Use StreamFeatureView.from_proto() for the stream_feature_views list
instead, matching the actual proto type of each entry.

Fixes feast-dev#6658

Signed-off-by: Carlos Sánchez <infsaarc@gmail.com>
@ntkathole
ntkathole force-pushed the fix/plan-stream-feature-view-typecheck branch from 86cf676 to d972891 Compare July 30, 2026 05:04
@ntkathole
ntkathole merged commit adb8c1c into feast-dev:master Jul 30, 2026
20 of 22 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Aug 21, 2026
# [0.66.0](v0.65.0...v0.66.0) (2026-08-21)

### Bug Fixes

* Add connection pre-warming for DynamoDB async client ([89240fa](89240fa)), closes [#6060](#6060)
* Add remote registry client extra ([#6697](#6697)) ([b8dfcb0](b8dfcb0))
* Address review feedback on FIPS cipher suite configuration ([4a35fba](4a35fba))
* Allow remote-registry first apply for new projects ([39d408d](39d408d))
* Avoid importing feast.feature_store at mcp_server import time ([ddb2e9a](ddb2e9a))
* Bump pymssql to >=2.3.6 for macOS arm64 wheel support ([181eb35](181eb35)), closes [#5636](#5636) [#5193](#5193) [#5636](#5636)
* Call ApplySavedDataset RPC instead of ApplyFeatureService in RemoteRegistry.apply_saved_dataset() ([934d341](934d341))
* Catch missing dbt parser dependency in dbt CLI commands ([#6534](#6534)) ([3c2ae3c](3c2ae3c))
* Default authentication to kubernetes auth ([6a4690a](6a4690a))
* Defer feature-freshness thread to post-fork to avoid Gunicorn deadlock ([#6648](#6648)) ([104ad10](104ad10)), closes [#6647](#6647)
* Do not pass undeclared feature view columns to ODFV UDFs ([#6527](#6527)) ([75b9463](75b9463))
* downgrade mcp pin to 1.29.0 and fix CI lockfiles and unit tests ([98e5bca](98e5bca)), closes [#6706](#6706)
* Feast apply silently ignoring ttl updates to None or timedelta(0) ([#6709](#6709)) ([97b0f25](97b0f25)), closes [#6703](#6703)
* Fix mypy TorchTensor type alias error ([#6712](#6712)) ([34de6fa](34de6fa)), closes [#5563](#5563)
* Fixed data source creation form gaps ([5d0f7d6](5d0f7d6))
* Handle parameterized and complex Trino types in type map ([326554d](326554d))
* Isolate default user permissions ([e37adbf](e37adbf))
* Isolate projection join key maps ([d1c709d](d1c709d))
* Map Postgres real to FLOAT instead of DOUBLE ([62db435](62db435))
* Merge shared ODFV source projections in feature resolution ([d269946](d269946)), closes [#6621](#6621)
* More exhaustive athena types ([a9aaefc](a9aaefc))
* Normalize SQL registry read_path to the psycopg3 driver like path ([#6644](#6644)) ([996c6ea](996c6ea)), closes [#6643](#6643)
* **operator:** add spec.services.onlineStore.disabled to opt out of the online store ([d81d4e3](d81d4e3)), closes [#6586](#6586)
* Preinstall DuckDB delta extension for tests ([fd4d49d](fd4d49d)), closes [#6743](#6743)
* Preserve event-time ordering within Redis online_write_batch ([40fb788](40fb788)), closes [#5163](#5163)
* Prevent mutation of cached feature resolution results ([ea17419](ea17419))
* Remote feastRef FeatureStore fails first apply for a new feastProject ([9affee5](9affee5))
* Remove inert subjectaccessreviews and reorganize RBAC rules ([f771ea4](f771ea4))
* Report single-feature-view spark_application materialization success ([a9219d9](a9219d9)), closes [#6673](#6673)
* Reset the global security manager after the permissions fixture ([7667215](7667215))
* Resolve kserve with pip --dry-run instead of installing it ([01da132](01da132)), closes [#6732](#6732)
* Resolve write_to_offline_store feature view with a single registry lookup ([a42dc85](a42dc85)), closes [#4235](#4235)
* Return False from __eq__ on cross-type comparison ([#6637](#6637)) ([0f149a9](0f149a9)), closes [#6636](#6636)
* Reuse IdP-issued client tokens until near expiry ([602d752](602d752))
* Reuse the OIDC JWKS client across requests ([#6683](#6683)) ([a1e6fc2](a1e6fc2))
* Separate CronJob and feature-server ServiceAccounts ([398f643](398f643))
* Serialize UnixTimestamp proto values as raw int64 in remote online store transport ([1e7134f](1e7134f))
* Set FIPS cipher suites before pyarrow.flight import to prevent crash on IBM Power ([979b82a](979b82a))
* Support Entra ID (Azure AD) token claims in OIDC auth ([#6631](#6631)) ([f843c63](f843c63))
* UDF/ODFV source rehydrate (+ Postgres / online cache) ([#6655](#6655)) ([5fd7af7](5fd7af7))
* Updated projects-list.json in order to display newly added projects ([#6657](#6657)) ([3a6a103](3a6a103))
* Use correct image name in multi-arch imagetools push step ([faf85e0](faf85e0))
* Use join keys instead of entity names in ODFV materialization ([#6645](#6645)) ([abffebc](abffebc)), closes [#5965](#5965)
* use matching proto class per feature view list in SqliteOnlineStore.plan() ([adb8c1c](adb8c1c)), closes [#6658](#6658)
* Widen Athena integer type mapping for unsigned ints ([3425783](3425783))

### Features

* Add ConnectionRef to DataSource for pluggable external credential resolution ([28bde01](28bde01))
* Add Feature Service Create in UI ([0399380](0399380))
* Add hybrid to ValidOfflineStoreDBStorePersistenceTypes for HybridOfflineStore support ([#6707](#6707)) ([310ab51](310ab51)), closes [#6701](#6701)
* Add MLflow integration support to Feast operator ([#6611](#6611)) ([52999f1](52999f1))
* Add opt-in filter_by_created_timestamp cutoff to get_historical_features ([#6617](#6617)) ([79b33ce](79b33ce)), closes [#6615](#6615)
* Add optional OIDC token audience and issuer verification ([#6670](#6670)) ([ef307c6](ef307c6))
* Add packaged feature repository support to Feast Operator ([8112b1e](8112b1e)), closes [#6598](#6598)
* add plan() support to DynamoDBOnlineStore ([51ce982](51ce982)), closes [#6658](#6658) [#6659](#6659)
* Added optional namespace/colleciton to datasets ([165fcf2](165fcf2))
* Added SQL registry schema_mode and registry create command ([#6704](#6704)) ([037c4cd](037c4cd))
* Allow users to have protected project on shared registry ([f9923bc](f9923bc))
* Apply Intermediate TLS defaults on API fallback and handle transient errors ([#6587](#6587)) ([43ae993](43ae993))
* **cli:** Updated feast init demo by adding rag template ([#5946](#5946)) ([c8628eb](c8628eb)), closes [#5264](#5264)
* Expose the OIDC JWKS tunables through the operator ([#6690](#6690)) ([fef4e78](fef4e78)), closes [#6683](#6683)
* Making feast vector store with open ai search api compatible ([#6121](#6121)) ([54da19a](54da19a))
* Multi-arch publish for feast operator image ([b221036](b221036))
* OpenLineage lineage enhancements - full object coverage, richer UI, and API-level sync ([#6719](#6719)) ([120a868](120a868))
* **operator:** Add spec.services.initImage for init container image override ([#6598](#6598)) ([ca355cb](ca355cb))
* Pass optional OIDC audience and issuer through the operator ([#6677](#6677)) ([a13ed7b](a13ed7b)), closes [#6670](#6670)
* **server:** Remote Materialization ([#6649](#6649)) ([b7ae488](b7ae488)), closes [#4526](#4526)
* Support Lineage configs via operator ([bf1e54a](bf1e54a))
* Updated datasets UI to support grouping ([7ae64ec](7ae64ec))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlite.py's OnlineStore.plan() raises typeguard.TypeCheckError for stream feature views

4 participants