fix(kit): icon appearance for step buttons in tables - #14747
Open
nullawhale wants to merge 1 commit into
Open
Conversation
nullawhale
requested review from
MarsiBarsi,
Yanduz,
mdlufy,
nsbarsukov,
vladimirpotekhin and
waterplea
and removed request for
a team
August 13, 2026 11:40
Contributor
Failed tests ❌Before (main) ← Diff → After (local)tests-demo-demo.pw-Demo-components-table-chromium-retry2/components-table/11.android.diff.png
tests-demo-demo.pw-Demo-components-table-chromium-retry2/components-table/11.desktop-rtl.diff.png
tests-demo-demo.pw-Demo-components-table-chromium-retry2/components-table/11.desktop.diff.png
tests-demo-demo.pw-Demo-components-table-chromium-retry2/components-table/11.ios.diff.png
(updated for commit 955159f) |
BundleMonUnchanged files (2)
Total files change +3B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
waterplea
reviewed
Aug 13, 2026
| protected readonly hold = inject(TuiInputNumberStepService<bigint | number>); | ||
|
|
||
| protected readonly buttonAppearance = computed(() => | ||
| this.appearance() === 'table' ? 'icon' : this.appearance(), |
Member
There was a problem hiding this comment.
'icon' has increased icon size due to lack of background, maybe 'flat-grayscale' would look better?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14612