Rate limit override - #5330
Open
Vamp1reAchao wants to merge 3 commits into
Open
Conversation
harshil21
requested changes
Aug 13, 2026
| @@ -0,0 +1 @@ | |||
| bugfixes = "Respect an explicit rate_limit_args=0 in AIORateLimiter" | |||
Member
There was a problem hiding this comment.
The file is missing a few more attributes, can you look at the other .tomls and update this?
Author
There was a problem hiding this comment.
Done, updated the changelog entry and reverted the unrelated test change. Thanks!
Member
There was a problem hiding this comment.
Can you also fix the failing prek action? Don't worry about the other failing tests
| assert all(task.done() for task in non_chat_tasks.values()) | ||
| assert all(task.done() for task in chat_tasks.values()) | ||
| finally: | ||
| # cleanup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix AIORateLimiter handling of rate_limit_args=0.
Previously, passing 0 could be treated as a falsy value and fall back to the configured default retry limit. This change distinguishes an explicitly provided 0 from None, allowing callers to intentionally disable retries for a specific request while preserving the global default behavior when no override is provided.
Includes regression tests covering both explicit 0 and fallback-to-default behavior.