chore: have EncodedId creation always return EncodedId - #2040
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2040 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 78 78
Lines 4985 4986 +1
=======================================
+ Hits 4670 4671 +1
Misses 315 315
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
marked this pull request as draft
May 31, 2022 19:17
JohnVillalovos
marked this pull request as ready for review
May 31, 2022 19:40
JohnVillalovos
force-pushed
the
jlvillal/type_alias
branch
from
May 31, 2022 19:45
e2dcdb4 to
c90cfa3
Compare
JohnVillalovos
marked this pull request as draft
May 31, 2022 19:52
There is no reason to return an `int` as we can always return a `str` version of the `int` Change `EncodedId` to always return an `EncodedId`. This removes the need to have `mypy` ignore the error raised.
JohnVillalovos
force-pushed
the
jlvillal/type_alias
branch
from
May 31, 2022 23:07
c90cfa3 to
a1a246f
Compare
JohnVillalovos
marked this pull request as ready for review
May 31, 2022 23:09
nejch
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reason to return an
intas we can always return astrversion of the
intChange
EncodedIdto always return anEncodedId. This removes theneed to have
mypyignore the error raised.