feat: import from bitbucket server - #1283
Merged
Merged
Conversation
Author
|
I cribbed this directly from the existing |
nejch
requested changes
Feb 4, 2021
nejch
left a comment
Member
There was a problem hiding this comment.
Looks great @fajpunk thanks! Just a few notes.
I was going to suggest adding some docs (like in https://github.com/python-gitlab/python-gitlab/blob/77ac8c300fc647f18d4a71b84ae18a751bc1716f/docs/gl_objects/projects.rst#import--export) but the docstring, like for github is already pretty descriptive.
I'd like to use this libary to automate importing Bitbucket Server repositories into GitLab. There is a [GitLab API endpoint](https://docs.gitlab.com/ee/api/import.html#import-repository-from-bitbucket-server) to do this, but it is not exposed through this library. * Add an `import_bitbucket_server` method to the `ProjectManager`. This method calls this GitLab API endpoint: https://docs.gitlab.com/ee/api/import.html#import-repository-from-bitbucket-server * Modify `import_gitlab` method docstring for python3 compatibility * Add a skipped stub test for the existing `import_github` method
nejch
reviewed
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to use this libary to automate importing Bitbucket Server
repositories into GitLab. There is a GitLab API
endpoint
to do this, but it is not exposed through this library.
import_bitbucket_servermethod to theProjectManager. Thismethod calls this GitLab API endpoint:
https://docs.gitlab.com/ee/api/import.html#import-repository-from-bitbucket-server
import_githubmethod