Skip to content

Add support to resource milestone events - #1157

Merged
max-wittig merged 4 commits into
python-gitlab:masterfrom
Shkurupii:issue-1154
Aug 29, 2020
Merged

Add support to resource milestone events#1157
max-wittig merged 4 commits into
python-gitlab:masterfrom
Shkurupii:issue-1154

Conversation

@Shkurupii

@Shkurupii Shkurupii commented Aug 26, 2020

Copy link
Copy Markdown

Closes #1154

@Shkurupii Shkurupii closed this Aug 26, 2020
@Shkurupii

Shkurupii commented Aug 26, 2020

Copy link
Copy Markdown
Author

Bad commit message

@Shkurupii Shkurupii reopened this Aug 26, 2020
@Shkurupii

Shkurupii commented Aug 26, 2020

Copy link
Copy Markdown
Author

@max-wittig take a look, please!

@max-wittig

max-wittig commented Aug 26, 2020

Copy link
Copy Markdown
Member

Thanks for the MR. Could you just please add some tests to it? 👍

@Shkurupii

Shkurupii commented Aug 26, 2020

Copy link
Copy Markdown
Author

What kind of tests? Please, elaborate. I am using "resourcelabelevents" for a starting point, so I have added to python_test_v4.py another two tests for milestones as same as for the resourcelabelevents.

@max-wittig

max-wittig commented Aug 27, 2020

Copy link
Copy Markdown
Member

You've added functional tests. Would you mind to also add some unittests here? https://github.com/python-gitlab/python-gitlab/tree/master/gitlab/tests/objects

@Shkurupii

Shkurupii commented Aug 29, 2020

Copy link
Copy Markdown
Author

@max-wittig Hi, check this out. Also, I can't understand why black fails my changes. WDYT? Please, advise.

@Shkurupii

Shkurupii commented Aug 29, 2020

Copy link
Copy Markdown
Author

@max-wittig Hi, check this out. Also, I can't understand why black fails my changes. WDYT? Please, advise.

Found out that Travis black is a higher version than mine. Add another commit to make linter happy.

max-wittig
max-wittig approved these changes Aug 29, 2020
View reviewed changes

@max-wittig max-wittig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the black breakage. I guess it makes sense to pin the version.

Thanks for the MR!

@max-wittig
max-wittig merged commit 750f4ee into python-gitlab:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-wittig max-wittig max-wittig approved these changes

Assignees

@Shkurupii Shkurupii

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for resource milestone events

2 participants

@Shkurupii @max-wittig