gh-155877: Reject an embedded NUL in curses cell text - #155878
Open
fedonman wants to merge 1 commit into
Open
Conversation
setcchar() stops at the first NUL, so a cell text containing one was
silently truncated: complexchar('a\0\u0301') dropped the combining
character, and complexchar('\0') built a cell with no text, whose
repr() is not a valid constructor call and which terminates the
cchar_t array passed to add_wchnstr().
The two cell construction paths, curses_cell_pack() and
complexstr_from_string(), now reject any NUL, and the shared converter
rejects a NUL inside a multi-character cell. A lone NUL still reaches
the write methods, so addch('\0') keeps writing what addch(0) writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curses.complexchar()andcurses.complexstr()now reject a text containing a NUL, and the shared cell converter rejects a NUL inside a multi-character cell, sowindow.addch()and its siblings no longer keep only the text before it. A lone NUL is still written likeaddch(0).No NEWS entry: the cell API has not been released.