fix: support for empty repeated options (#1715) - #1716
Open
steinybot wants to merge 1 commit into
Open
Conversation
steinybot
commented
May 12, 2022
|
|
||
| test.test(test.name + " - message options (Empty)", function (test) { | ||
| var TestMessageOptionsMsg = root.lookup("TestMessageOptionsEmpty"); | ||
| test.equal("(mo_rep_msg).rep_value" in TestMessageOptionsMsg.options, false, "should treat empty repeated option as missing"); |
Contributor
Author
There was a problem hiding this comment.
Is this the right thing to do for this case?
I would have thought that options would get defaults just like any other value but is that at a higher level than the parser?
steinybot
force-pushed
the
fix/empty-repeated-options
branch
from
September 8, 2022 22:50
6904a93 to
843fada
Compare
Contributor
Author
|
Anyone able to review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1715