ext/zip: Fix AES-192 and AES-256 support reporting in phpinfo() - #23319
Merged
Conversation
LamentXU123
added a commit
that referenced
this pull request
Aug 16, 2026
* PHP-8.5: ext/zip: Fix AES-192 and AES-256 support reporting in phpinfo() (#23319)
pull Bot
pushed a commit
to wudi/php-src
that referenced
this pull request
Aug 16, 2026
* PHP-8.4: ext/zip: Fix AES-192 and AES-256 support reporting in phpinfo() (php#23319)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am speechless. I firstly thought my environment is broken because I seem to be testing my patch on a libzip implementation that doesn't support some of the aes method, and after hours of researching, I find out that phpinfo() shows the wrong constant.
Now, AES-128, AES-192, AES-256 are added in a same version. However, this is still not a robust way to tell if we actually support them. Obviously, using their own macro will be better instead of all using aes-128's. This makes the phpinfo page effectively useless.