dgram: remove unnecessary fd property from Socket - #21684
Closed
oyyd wants to merge 1 commit into
Closed
Conversation
cjihrig
reviewed
Jul 6, 2018
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
In theory this LGTM as a semver-major, but it might need a CITGM run.
addaleax
approved these changes
Jul 6, 2018
JungMinu
approved these changes
Jul 7, 2018
Contributor
Author
jasnell
reviewed
Jul 10, 2018
Member
There was a problem hiding this comment.
hmm... @nodejs/tsc ... do we know if this could break anyone? It may be minor, but we should likely do a deprecation on this before just removing it.
Member
There was a problem hiding this comment.
I think a simple semver-major removal is fine for this, given that it seems pretty unusable.
Member
|
This needs another @nodejs/tsc review |
cjihrig
approved these changes
Jul 19, 2018
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
Sorry, I guess I didn't make my LGTM explicit enough before.
Contributor
|
@oyyd Can you rebase this PR please? |
It seems the property socket.fd is used long before for the compatibility reason but it's not used anymore. It's also not documented in docs so that it's not a public api/property. Keep the property also make the code a bit confusing as socket._handle.fd is the actual property representing fd.
oyyd
force-pushed
the
udp-unnecessary-fd
branch
from
August 10, 2018 02:51
b0c3494 to
4fa3fbd
Compare
Contributor
Author
|
@maclover7 PTAL |
Contributor
maclover7
approved these changes
Aug 10, 2018
Contributor
|
CI is green besides for worker tests which are having infra issues right now, this should be safe to land |
Contributor
|
Landed in 3ce6bc3 |
maclover7
pushed a commit
that referenced
this pull request
Aug 10, 2018
It seems the property socket.fd is used long before for the compatibility reason but it's not used anymore. It's also not documented in docs so that it's not a public api/property. Keep the property also make the code a bit confusing as socket._handle.fd is the actual property representing fd. PR-URL: #21684 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the property
socket.fdis used long before for the compatibility reason but it's not used anymore.It's also not documented in docs so that it's not a public api/property.
Keep the property also makes the code a bit confusing as
socket._handle.fdis the actual property representing fd.make -j4 test(UNIX), orvcbuild test(Windows) passes