Honor JSpecify nullability of reused mapping methods - #4110
Open
kush2439p wants to merge 1 commit into
Open
Conversation
kush2439p
marked this pull request as ready for review
August 10, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4106 by carrying the JSpecify input and output contracts of reused mapping methods through generated assignments.
MapStruct previously based null guards primarily on source/target nullability and null-value-check strategy. It did not retain whether a selected helper method required a non-null argument or guaranteed a non-null result, which could generate unsafe calls or reject safe constructor mappings.
Implementation
usestypes.-Amapstruct.disableJSpecify=true.This also covers the related scenarios described in #4077, #4081, and #4086 without adding public API.
Verification
JSpecify*Testsuite: 111 tests passed.MavenIntegrationTest#fullFeatureTest: passed.The full reactor
clean install -DskipDistribution=trueexceeded the local 15-minute command limit after the processor suite completed; the affected integration path and Checkstyle were rerun successfully afterward.