C#: Simplify the Nuget Package restorer. - #22094
Merged
Merged
Conversation
michaelnebel
force-pushed
the
csharp/removetimeoutcase
branch
from
August 13, 2026 09:50
b8ee7dd to
0ed230c
Compare
michaelnebel
force-pushed
the
csharp/removetimeoutcase
branch
2 times, most recently
from
August 14, 2026 07:58
97cf027 to
a2c20f7
Compare
michaelnebel
force-pushed
the
csharp/removetimeoutcase
branch
from
August 19, 2026 13:10
a2c20f7 to
00816ca
Compare
michaelnebel
force-pushed
the
csharp/removetimeoutcase
branch
from
August 20, 2026 09:35
00816ca to
8a747a6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Simplifies C# NuGet restoration so dotnet restore is attempted after feed timeouts before using fallback restoration.
Changes:
- Removes timeout-specific early fallback behavior.
- Simplifies feed reachability APIs.
- Updates integration baselines and change notes.
Show a summary per file
| File | Description |
|---|---|
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs |
Continues normal restoration after feed timeouts. |
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs |
Removes unused timeout tracking. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_fallback/CompilationInfo.expected |
Updates generated metrics baseline. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_error_timeout/CompilationInfo.expected |
Updates generated timeout metrics baseline. |
csharp/ql/lib/change-notes/2026-08-20-dotnet-restore.md |
Documents the restoration behavior change. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
hvitved
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
dotnet restoreon projects/solutions even if there is a feed timeout (but only use the reachable feeds) and only use the fallback feed logic for everything that is not restored usingdotnet restore.Testing
cs/simplifiable-boolean-expression, but this is because the nightly that is used as base doesn't contain a specific PR, which removes some FPs for this particular query (but the PR branch does). The issue for QA run can be seen here - note that this is only internally available for GitHub.