Skip to content

feat(curriculum): Add data sanitizer sweep lab - #67313

Open
MarkI2 wants to merge 93 commits into
freeCodeCamp:mainfrom
MarkI2:feature/64126-data-sanitizer-sweep-lab
Open

feat(curriculum): Add data sanitizer sweep lab #67313
MarkI2 wants to merge 93 commits into
freeCodeCamp:mainfrom
MarkI2:feature/64126-data-sanitizer-sweep-lab

Conversation

@MarkI2

@MarkI2 MarkI2 commented May 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Checklist:

Closes #64126

MarkI2 and others added 14 commits April 27, 2026 14:14
@MarkI2
Followed the instruction and created the lab
43f0f1c
@MarkI2
Adding in description and objective as per readme file from CE protot…
d4b5bd2 
…ype.
@MarkI2
Having problem committing md file with ''' trialing if this works
c4dfd04
@MarkI2
Merge branch 'freeCodeCamp:main' into feature/64126-data-sanitizer-sw…
5da9721 
…eep-lab
@MarkI2
Adding extra code for seed content
dd0f94e
@MarkI2
Complete draft for the test cases and adding further information for …
b7dd2df 
…description.
@MarkI2
Remove placeholder code
6b802c6
@MarkI2
Seeding sample code along with extra comments
927313b
@MarkI2
Merge branch 'freeCodeCamp:main' into feature/64126-data-sanitizer-sw…
ee6f399 
…eep-lab
@MarkI2
Fixing typo and adding solution
2a4d14b
@MarkI2
Changing solution as well as the conditions of success passing.
3c6f043
@MarkI2
Reworking the print method to 2 console.log instead of a function for…
25a4b81 
… simplicity.

Change the info character from // to /
@MarkI2
Some clean up of description
a5df39d
@MarkI2
Merge branch 'freeCodeCamp:main' into feature/64126-data-sanitizer-sw…
c30e7fa 
…eep-lab
@github-actions github-actions Bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels May 10, 2026
@github-actions github-actions Bot changed the title Issue: 64126 data sanitizer sweep lab fix: Issue: 64126 data sanitizer sweep lab May 10, 2026
@github-actions github-actions Bot added the Naomi's Sprints This label is for issues that Naomi is managing through her sprint initiatives on Discord. label May 10, 2026
majestic-owl448
majestic-owl448 reviewed May 10, 2026
View reviewed changes

@majestic-owl448 majestic-owl448 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the folder and block can't be named data-sanitizer-sweep, a lab dashed name needs to start with lab- (it can stay as dashedName inside the challenge file tho)

majestic-owl448
majestic-owl448 reviewed May 10, 2026
View reviewed changes
Comment thread curriculum/structure/blocks/lab-data-sanitizer-sweep.json Outdated
@majestic-owl448 majestic-owl448 added the js v9 cert This is for the JS V9 certification. label May 13, 2026
majestic-owl448
majestic-owl448 reviewed May 15, 2026
View reviewed changes
Comment thread client/i18n/locales/english/intro.json Outdated
@camper-chan camper-chan Bot added status: waiting update Is awaiting update, after feedback or request for changes and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Jul 24, 2026
@MarkI2

MarkI2 commented Jul 25, 2026

Copy link
Copy Markdown
Author

I've just reviewed the user stories and all seems very confused. There's a lot of repetitions in places where you are not supposed to deal with that precise aspect of the expected solution, and this makes things even more confused.

The solution checks for fatal characters only at the beginning of the entry, and this is in contrast with the example in the description.

Also, when the fatal character is found it would make sense to return the report of sanitized entries so far followed by the error.

And why should a skipped entry count as successfully sanitized?

Reason for counting skipped entry as successfully sanitized entry was more hoping to simplify the lab therefore students will only need to track 2 types of counts: sanitized and unsanitized counts.

I'm currently reviewing the whole PR so I will be putting it back to draft and redo it.

@MarkI2

MarkI2 commented Jul 25, 2026

Copy link
Copy Markdown
Author

I've just reviewed the user stories and all seems very confused. There's a lot of repetitions in places where you are not supposed to deal with that precise aspect of the expected solution, and this makes things even more confused.

The solution checks for fatal characters only at the beginning of the entry, and this is in contrast with the example in the description.

Also, when the fatal character is found it would make sense to return the report of sanitized entries so far followed by the error.

And why should a skipped entry count as successfully sanitized?

Thanks for your review

Reason for counting skipped entry as successfully sanitized entry was more hoping to simplify the lab therefore students will only need to track 2 types of counts: sanitized and unsanitized counts.

I'm currently reviewing the whole PR so I will be putting it back to draft and redo it.

@MarkI2
MarkI2 marked this pull request as draft July 26, 2026 02:38
MarkI2 and others added 8 commits July 26, 2026 19:24
@MarkI2
Merge branch 'freeCodeCamp:main' into feature/64126-data-sanitizer-sw…
27bd821 
…eep-lab
@MarkI2
fix(curriculum): Reverting a typo in the solution
9fd80fd
@MarkI2 @Dario-DC
Update client/i18n/locales/english/intro.json
ae8c089 
Co-authored-by: Dario <105294544+Dario-DC@users.noreply.github.com>
Signed-off-by: MarkI2 <39160791+MarkI2@users.noreply.github.com>
@MarkI2 @Dario-DC
Update curriculum/challenges/english/blocks/lab-data-sanitizer-sweep/…
82d907f 
…69eefea5a952ae85871df0dc.md

Co-authored-by: Dario <105294544+Dario-DC@users.noreply.github.com>
Signed-off-by: MarkI2 <39160791+MarkI2@users.noreply.github.com>
@MarkI2 @Dario-DC
Update curriculum/challenges/english/blocks/lab-data-sanitizer-sweep/…
7d8c971 
…69eefea5a952ae85871df0dc.md

Co-authored-by: Dario <105294544+Dario-DC@users.noreply.github.com>
Signed-off-by: MarkI2 <39160791+MarkI2@users.noreply.github.com>
@MarkI2
Merge branch 'freeCodeCamp:main' into feature/64126-data-sanitizer-sw…
1a9484c 
…eep-lab
@MarkI2
fix: fixing solution error. split informational line check separately.
b9c27ac 
Add console.log line to the fatal error section.
@MarkI2
feat: Change up user story to add reflect changed solution change.
e677808
@majestic-owl448

majestic-owl448 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

when you are ready for a new review, let us know by marking the PR as ready for review

@majestic-owl448 majestic-owl448 removed the status: waiting update Is awaiting update, after feedback or request for changes label Aug 3, 2026
MarkI2 and others added 12 commits August 8, 2026 16:59
@MarkI2
feat(curriculum): Add 2 hardcode guard to test for sanitizedLog
f254595
@MarkI2
Merge branch 'main' into feature/64126-data-sanitizer-sweep-lab
6ed967b
@MarkI2
feat(curriculum): extra hardcode guard test added.
0546c41
@MarkI2
feat: removing redundant user story informations and removing seed-co…
3890d2d 
…ntents that was causing correct solution failure.
@MarkI2
Merge branch 'main' into feature/64126-data-sanitizer-sweep-lab
cefe310
@MarkI2
fix: Fix up the user story and remove redundant info
a73aaae
@MarkI2
fix: consolidate user story
66c1da2
@MarkI2
Merge branch 'freeCodeCamp:main' into feature/64126-data-sanitizer-sw…
58022d8 
…eep-lab
@MarkI2
fix: reworking the user story and description. Include 1 example in d…
b146768 
…escription and all other information goes to user story.

Trying to add spyon was causing the check 6 to fail with or without variable used in console.log. So taking out the console.log requirement in user story 5.
@MarkI2
Add more info.
8800428
@MarkI2
fix: remove typos.
69fc876
@MarkI2
fix: remove inconsistencies.
1471a87
@MarkI2
MarkI2 marked this pull request as ready for review August 16, 2026 04:53
@MarkI2
MarkI2 requested a review from Dario-DC August 16, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majestic-owl448 majestic-owl448 majestic-owl448 left review comments
@Dario-DC Dario-DC Awaiting requested review from Dario-DC

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

js v9 cert This is for the JS V9 certification. Naomi's Sprints This label is for issues that Naomi is managing through her sprint initiatives on Discord. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lab – Data Sanitizer Sweep

3 participants

@MarkI2 @majestic-owl448 @Dario-DC