[nexmark] Port Nexmark unit test data from Rust to SQL/Java - #6783
[nexmark] Port Nexmark unit test data from Rust to SQL/Java#6783mihaibudiu wants to merge 1 commit into
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM — solid cleanup. Five real bugs fixed (Q6 ARG_MAX argument swap, Q7 TUMBLE_START→TUMBLE_END, Q20 test calling createTest(19,…) instead of 20, Q22 splitting channel instead of url, Q22 empty-string vs NULL), plus the format function rename. Every previously-empty test stub now has real assertions, and coverage is strictly stronger than before.
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM — solid cleanup. Five real bugs fixed (Q6 ARG_MAX argument swap, Q7 TUMBLE_START→TUMBLE_END, Q20 test calling createTest(19,…) instead of 20, Q22 splitting channel instead of url, Q22 empty-string vs NULL), plus the format function rename. Every previously-empty test stub now has real assertions, and coverage is strictly stronger than before.
Fixes #164
This also fixes bugs in 3 manual Rust query implementations.
This fix only includes the unit tests, it does nothing for the Nexmark benchmark.
There are still 2 queries unsupported, but we can close these two soon as well: Q11 needs session windows, for which I just opened a PR, and Q21 needs REGEXP_EXTRACT, which should be easy to implement (modulo the differences between Java and Rust regular expressions).
Checklist
(This was the oldest open issue assigned to me, so I had to close it.)