feat: ES module build - #3375
Closed
daffl wants to merge 13 commits into
Closed
Conversation
daffl
marked this pull request as draft
December 22, 2023 21:56
Deploying with
|
| Latest commit: |
1af1513
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d5f1801c.feathers.pages.dev |
| Branch Preview URL: | https://es-modules.feathers.pages.dev |
daffl
marked this pull request as ready for review
December 23, 2023 00:02
Member
Author
|
Well this doesn't seem to be working at all. Even just migrating the CLI to ES modules (starting with #3386) caused a whole rats tail of weird and unexpected issues. |
Closed
Member
Author
|
Full ES module support is now working in https://github.com/feathersjs/feathers/tree/v6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds ES module builds for all packages.