-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Apply Intermediate TLS defaults on API fallback and handle transient errors #6587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ntkathole
merged 2 commits into
feast-dev:master
from
ugiordan:feat/tls-intermediate-fallback
Jul 30, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| /* | ||
| Copyright 2024 Feast Community. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "crypto/tls" | ||
| "errors" | ||
| "fmt" | ||
| "time" | ||
|
|
||
| configv1 "github.com/openshift/api/config/v1" | ||
| tlspkg "github.com/openshift/controller-runtime-common/pkg/tls" | ||
| apierrors "k8s.io/apimachinery/pkg/api/errors" | ||
| apimeta "k8s.io/apimachinery/pkg/api/meta" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/log" | ||
| ) | ||
|
|
||
| const ( | ||
| tlsFetchTimeout = 10 * time.Second | ||
| alpnH2 = "h2" | ||
| alpnHTTP11 = "http/1.1" | ||
| ) | ||
|
|
||
| type tlsBootstrapResult struct { | ||
| TLSOpts []func(*tls.Config) | ||
| ProfileFetched bool | ||
| ProfileSpec configv1.TLSProfileSpec | ||
| AdherenceFetched bool | ||
| AdherencePolicy configv1.TLSAdherencePolicy | ||
| UnsupportedCiphers []string | ||
| } | ||
|
|
||
| func fetchTLSProfile(ctx context.Context, k8sClient client.Client) (configv1.TLSProfileSpec, bool, error) { | ||
| fetchCtx, cancel := context.WithTimeout(ctx, tlsFetchTimeout) | ||
| defer cancel() | ||
|
|
||
| profile, err := tlspkg.FetchAPIServerTLSProfile(fetchCtx, k8sClient) | ||
| if err != nil { | ||
| return classifyTLSProfileError(err) | ||
| } | ||
| return profile, true, nil | ||
| } | ||
|
|
||
| func classifyTLSProfileError(err error) (configv1.TLSProfileSpec, bool, error) { | ||
| intermediate := *configv1.TLSProfiles[configv1.TLSProfileIntermediateType] | ||
|
|
||
| switch { | ||
| case apimeta.IsNoMatchError(err): | ||
| return intermediate, false, nil | ||
| case apierrors.IsNotFound(err): | ||
| return intermediate, false, nil | ||
| case isTransientError(err): | ||
| return intermediate, true, nil | ||
| default: | ||
| return configv1.TLSProfileSpec{}, false, fmt.Errorf("unable to read APIServer TLS profile: %w", err) | ||
| } | ||
| } | ||
|
|
||
| func fetchTLSAdherencePolicy(ctx context.Context, k8sClient client.Client) (configv1.TLSAdherencePolicy, bool, error) { | ||
| fetchCtx, cancel := context.WithTimeout(ctx, tlsFetchTimeout) | ||
| defer cancel() | ||
|
|
||
| policy, err := tlspkg.FetchAPIServerTLSAdherencePolicy(fetchCtx, k8sClient) | ||
| if err == nil { | ||
| return policy, true, nil | ||
| } | ||
|
|
||
| switch { | ||
| case apimeta.IsNoMatchError(err), | ||
| apierrors.IsNotFound(err), | ||
| isTransientError(err): | ||
| return "", false, nil | ||
| default: | ||
| return "", false, fmt.Errorf("unable to read APIServer TLS adherence policy: %w", err) | ||
| } | ||
| } | ||
|
|
||
| func bootstrapTLS(ctx context.Context, k8sClient client.Client) (*tlsBootstrapResult, error) { | ||
| logger := log.FromContext(ctx) | ||
| result := &tlsBootstrapResult{ | ||
| TLSOpts: make([]func(*tls.Config), 0, 2), | ||
| } | ||
|
|
||
| profile, profileFetched, err := fetchTLSProfile(ctx, k8sClient) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| result.ProfileFetched = profileFetched | ||
| result.ProfileSpec = profile | ||
|
|
||
| tlsConfigFn, unsupported := tlspkg.NewTLSConfigFromProfile(profile) | ||
| result.UnsupportedCiphers = unsupported | ||
| if len(unsupported) > 0 { | ||
| logger.Info("TLS profile contains ciphers unsupported by Go", "unsupported", unsupported) | ||
| } | ||
| result.TLSOpts = append(result.TLSOpts, tlsConfigFn) | ||
|
|
||
| adherence, adherenceFetched, err := fetchTLSAdherencePolicy(ctx, k8sClient) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| result.AdherenceFetched = adherenceFetched | ||
| result.AdherencePolicy = adherence | ||
|
|
||
| result.TLSOpts = append(result.TLSOpts, func(c *tls.Config) { | ||
| c.NextProtos = []string{alpnH2, alpnHTTP11} | ||
| }) | ||
|
|
||
| return result, nil | ||
| } | ||
|
|
||
| func isTransientError(err error) bool { | ||
| return apierrors.IsServiceUnavailable(err) || | ||
| apierrors.IsTimeout(err) || | ||
| apierrors.IsServerTimeout(err) || | ||
| apierrors.IsTooManyRequests(err) || | ||
| errors.Is(err, context.DeadlineExceeded) | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dead code - function returns error but can never return a non-nil error.