Fix DELETE key not being recognized - #611
Merged
Merged
Conversation
curtsies stopped supporting PADDELETE at this point: thomasballinger/curtsies@4150164 fixes bpython#609
Member
|
Thanks, lgtm. Any thoughts on whether Curtsies should report this as delete or paddelete? The change brought Curtsieskey names in line with Blessed names which I trusted more than the names I had. |
Contributor
Author
|
I think DELETE is more clear and succinct than PADDELETE. |
|
@thomasballinger @bkad Thanks! |
|
|
||
|
|
||
| @edit_keys.on('<PADDELETE>') | ||
| @edit_keys.on('<DELETE>') |
Contributor
There was a problem hiding this comment.
Should this handle both DELETE and PADDELETE?
There was a problem hiding this comment.
On Manjaro Linux (Arch) <PADDELETE> doesn't worked either.
Pypi's package doesn't have this change.
Member
There was a problem hiding this comment.
@sebastinas Right now in curtsies there isn't a PADDELETE, but it wouldn't hurt to add it if paddelete should do this too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curtsies stopped supporting PADDELETE at this point: thomasballinger/curtsies@4150164
fixes #609