fix(core): sanitize meta selectors - #68836
Merged
Merged
Conversation
Ensure that property/name are correctly escaped and doesn't break out of the intended selector.
JeanMeche
force-pushed
the
fix/meta-selector
branch
from
May 21, 2026 00:27
de1a51b to
173f47e
Compare
JeanMeche
force-pushed
the
fix/meta-selector
branch
from
May 21, 2026 01:02
173f47e to
c2dcf4e
Compare
alan-agius4
reviewed
May 21, 2026
AndrewKushnir
approved these changes
May 22, 2026
AndrewKushnir
approved these changes
May 22, 2026
| @@ -102,7 +102,8 @@ export class Meta { | |||
| */ | |||
| getTag(attrSelector: string): HTMLMetaElement | null { | |||
| if (!attrSelector) return null; | |||
| return this._doc.querySelector(`meta[${attrSelector}]`) || null; | |||
| const meta = this._doc.querySelector(`meta[${attrSelector}]`); | |||
| return meta?.nodeName.toLowerCase() === 'meta' ? meta : null; | |||
Contributor
There was a problem hiding this comment.
nit: should we create a helper method like isMetaTag to avoid repetition and also minimize the risk of logic divergence in the future?
Member
Author
There was a problem hiding this comment.
I'll do that in the followup cleanup !
Member
This was referenced May 27, 2026
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that property/name are correctly escaped and doesn't break out of the intended selector.