Feat: Created matrix search function with test cases - #1559
Closed
developerr-ayush wants to merge 1 commit into
Closed
Feat: Created matrix search function with test cases#1559developerr-ayush wants to merge 1 commit into
developerr-ayush wants to merge 1 commit into
Conversation
developerr-ayush
marked this pull request as ready for review
October 21, 2023 03:31
developerr-ayush
requested review from
appgurueu and
raklaptudirm
as code owners
October 21, 2023 03:31
Contributor
Author
|
hey can i get hectoberfest label? |
Contributor
Author
|
@appgurueu any improvement on this pr? |
Contributor
Author
|
its been 3 days waiting for your review. |
Member
|
@appgurueu I don't think this algorithm provides any more educational information compared to a simple array linear search. What do you think? |
Collaborator
Agreed. This is effectively a linear search on the cells of the matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.