Skip to content

algorithm class: circle - #1252

Merged
raklaptudirm merged 4 commits into
TheAlgorithms:masterfrom
Japoncio3k:circlePerimeter
Oct 31, 2022
Merged

algorithm class: circle#1252
raklaptudirm merged 4 commits into
TheAlgorithms:masterfrom
Japoncio3k:circlePerimeter

Conversation

@Japoncio3k

@Japoncio3k Japoncio3k commented Oct 30, 2022 •
edited by gitpod-io Bot
Loading

Copy link
Copy Markdown
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu requested changes Oct 30, 2022
View reviewed changes

@appgurueu appgurueu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this in a Circle class together with the area of a circle.

@Japoncio3k

Japoncio3k commented Oct 30, 2022

Copy link
Copy Markdown
Contributor Author

should i do both the area and the perimeter in one commit?

@appgurueu

appgurueu commented Oct 30, 2022

Copy link
Copy Markdown
Collaborator

Yes

@Japoncio3k
Japoncio3k requested a review from appgurueu October 30, 2022 13:47
appgurueu
appgurueu reviewed Oct 30, 2022
View reviewed changes
Comment thread Geometry/Test/Circle.test.js Outdated
@Japoncio3k
Japoncio3k requested a review from appgurueu October 30, 2022 14:16
@raklaptudirm raklaptudirm changed the title Added circle perimeter algorithm class: circle Oct 31, 2022
@raklaptudirm
raklaptudirm merged commit 7256e53 into TheAlgorithms:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes
@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Japoncio3k @appgurueu @raklaptudirm