unicodedata: Removed unneeded UnicodeVersion struct - #8131

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

crates/stdlib/src/unicodedata.rs (1)

533-558: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Deduplicate the version-string formatting.

The X.Y.Z formatting is repeated three times: the modern branch here, the module-level unidata_version (Line 552), and they share identical logic differing only in the version tuple. Extract the differing tuple, then format once.

♻️ Proposed refactor

Add a small helper:

fn unicode_version_string(modern: bool) -> String {
    let (major, minor, patch) = if modern {
        char::UNICODE_VERSION
    } else {
        (3, 2, 0)
    };
    format!("{major}.{minor}.{patch}")
}

Then collapse both call sites:

         #[pygetset]
         fn unidata_version(&self) -> String {
-            if self.modern {
-                format!(
-                    "{}.{}.{}",
-                    char::UNICODE_VERSION.0,
-                    char::UNICODE_VERSION.1,
-                    char::UNICODE_VERSION.2
-                )
-            } else {
-                "3.2.0".into()
-            }
+            unicode_version_string(self.modern)
         }

     #[pyattr]
     fn unidata_version(_vm: &VirtualMachine) -> String {
-        format!(
-            "{}.{}.{}",
-            char::UNICODE_VERSION.0,
-            char::UNICODE_VERSION.1,
-            char::UNICODE_VERSION.2
-        )
+        unicode_version_string(true)
     }

As per coding guidelines: "When branches differ only in a value but share common logic, extract the differing value first, then call the common logic once to avoid duplicate code."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/stdlib/src/unicodedata.rs` around lines 533 - 558, The version string
formatting logic in `X.Y.Z` format is duplicated in both the `modern` branch and
the `unidata_version` function. Create a helper function that accepts a boolean
parameter to determine whether to use modern (char::UNICODE_VERSION) or legacy
(3, 2, 0) version tuples, then format the version string once within that
helper. Replace both the conditional formatting in the `modern` branch and the
formatting in the `unidata_version` function body with calls to this new helper
to eliminate the duplication.

Source: Coding guidelines