Add the ssl stdlib module by coolreader18 · Pull Request #1823 · RustPython/RustPython

coolreader18 · 2020-03-21T05:51:19Z

This is all VERY flaky, with many uses of unsafe. I'm not sure if this is a good idea at this point, but it does work, ~~albeit not certificate verification~~. EDIT: certificate verification does work, just not with google.com. @palaviv what's the deal? 😄

from urlllib.request import urlopen
print(urlopen("https://rustpython.github.io").read().decode())

coolreader18 · 2020-03-22T04:26:25Z

Okay, I think this is in half-decent shape now. If anyone has experience with openssl, I'd love to hear any ideas about why certificate verification isn't working.

coolreader18 · 2020-03-24T05:25:18Z

Nevermind, certificate verification does work, just not with google.com for some reason.

palaviv

Very impressive work!!!

palaviv · 2020-03-27T08:54:01Z

 num_cpus = "1"
 socket2 = { version = "0.3", features = ["unix"] }
 rustyline = "6.0"
+openssl = "0.10"


Have we considered something pure rust? Maybe RusTLS?

I looked into it, but _ssl's API pretty directly corresponds to OpenSSL's API; I don't think it would be guaranteed that everything we needed would be present in rustls.

coolreader18 · 2020-03-28T20:07:52Z

Is this good to merge?

youknowone · 2020-03-30T01:39:23Z

+    #[pymethod]
+    fn set_ciphers(&self, cipherlist: PyStringRef, vm: &VirtualMachine) -> PyResult<()> {
+        let ciphers = cipherlist.as_str();
+        if ciphers.contains('0') {


probably ciphers.contains(0 as char)?

😳 yep, I meant '\0'

having a test for this method call will be good to ensure this is correctly working

coolreader18 · 2020-03-30T04:37:52Z

Also, would it be best to vendor openssl by using the vendored feature for rust-openssl? It would increase binary size, but it would also get rid of a lot of issues with linking to openssl (I don't think any of the weird Windows stuff would be necessary). Maybe best to only vendor on windows, if possible?

youknowone · 2020-03-30T12:20:05Z

I have no idea about rust-openssl part but this PR looks good to me

coolreader18 · 2020-04-01T03:41:46Z

I think I'll look into vendoring-only-on-windows by contributing something to rust-openssl, I don't think it's possible otherwise, and it works for now.

palaviv · 2020-04-04T10:48:23Z

Also, would it be best to vendor openssl by using the vendored feature for rust-openssl? It would increase binary size, but it would also get rid of a lot of issues with linking to openssl (I don't think any of the weird Windows stuff would be necessary). Maybe best to only vendor on windows, if possible?

This fails on my PC without the vendored feature. I would suggest adding this by default to avoid problems with different systems and versions of OpenSSL.

$@coolreader18$

coolreader18 force-pushed the coolreader18/stdlib-ssl branch 8 times, most recently from a61f0ed to a37c9c8 Compare March 22, 2020 04:09

$@coolreader18$

coolreader18 marked this pull request as ready for review March 22, 2020 04:13

$@coolreader18$ coolreader18 mentioned this pull request Mar 24, 2020

Add SslMethod::tls_{client,server} rust-openssl/rust-openssl#1249

Merged

$@coolreader18$

coolreader18 force-pushed the coolreader18/stdlib-ssl branch from 80dd6ff to 6281f9c Compare March 25, 2020 03:41

$@coolreader18$

coolreader18 requested review from palaviv and youknowone and removed request for palaviv March 25, 2020 19:50

$palaviv$

palaviv approved these changes Mar 27, 2020

View reviewed changes

$@coolreader18$

coolreader18 force-pushed the coolreader18/stdlib-ssl branch from 95e92fe to 509ac5a Compare March 27, 2020 16:03

$youknowone$

youknowone approved these changes Mar 27, 2020

View reviewed changes

Comment thread vm/src/pyobject.rs

Comment thread vm/src/stdlib/ssl.rs Outdated

$@coolreader18$

coolreader18 force-pushed the coolreader18/stdlib-ssl branch from 509ac5a to 5b7ee53 Compare March 27, 2020 17:41

coolreader18 added 8 commits March 27, 2020 14:40

$@coolreader18$

Fix int.from_bytes() with an arbitrary iterator

d243b73

$@coolreader18$

Add ipaddress.py from CPython 3.6

0f4b358

$@coolreader18$

Add ssl.py from CPython 3.6

d3cc360

$@coolreader18$

Edit ssl.py slightly

255b5a6

$@coolreader18$

impl TryFromObject for CString

2893117

$@coolreader18$

Add socket.getsockopt, impl io::{Read,Write} for PySocketRef

a42e94b

$@coolreader18$

Add _ssl stdlib module

40835b1

$@coolreader18$

Install openssl on Windows in GH Actions

72f7cd6

$@coolreader18$

coolreader18 force-pushed the coolreader18/stdlib-ssl branch from 5b7ee53 to 1486b65 Compare March 27, 2020 19:40

coolreader18 added 8 commits March 27, 2020 15:24

$@coolreader18$

Don't use the matches!() macro

03ba022

$@coolreader18$

Make ssl work on windows

bea6e54

$@coolreader18$

Try a few things to make cert verification work

5885898

$@coolreader18$

Add OPENSSL_VERSION constants

31905bd

$@coolreader18$

Add ssl.RAND_* functions

12c57ce

$@coolreader18$

Make rustpython -i script.py work like it does in CPython

126f41e

$@coolreader18$

Add ctx.load_verify_locations(cadata=), and ctx.get_ca_certs

4f64afb

$@coolreader18$

Add _SSLSocket.peer_certificate

4fc45d2

$@coolreader18$

coolreader18 force-pushed the coolreader18/stdlib-ssl branch from 277ac0b to d10714d Compare March 27, 2020 20:24

$youknowone$

youknowone reviewed Mar 30, 2020

View reviewed changes

$@coolreader18$

Manually error on embedded nul for set_ciphers

7051b25

$@coolreader18$

coolreader18 force-pushed the coolreader18/stdlib-ssl branch from d10714d to 7051b25 Compare April 1, 2020 03:40

$@coolreader18$

coolreader18 merged commit c1c9631 into master Apr 1, 2020

$@coolreader18$

coolreader18 deleted the coolreader18/stdlib-ssl branch April 1, 2020 16:34

$@palaviv$ palaviv mentioned this pull request Apr 4, 2020

Use vendored version of openssl #1841

Merged

Uh oh!

Conversation

coolreader18 commented Mar 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coolreader18 commented Mar 22, 2020

Uh oh!

coolreader18 commented Mar 24, 2020

Uh oh!

palaviv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

palaviv Mar 27, 2020

Choose a reason for hiding this comment

Uh oh!

coolreader18 Mar 27, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coolreader18 commented Mar 28, 2020

Uh oh!

youknowone Mar 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coolreader18 Mar 30, 2020

Choose a reason for hiding this comment

Uh oh!

youknowone Mar 30, 2020

Choose a reason for hiding this comment

Uh oh!

coolreader18 commented Mar 30, 2020

Uh oh!

youknowone commented Mar 30, 2020

Uh oh!

coolreader18 commented Apr 1, 2020

Uh oh!

palaviv commented Apr 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

$@coolreader18$ coolreader18 commented Mar 21, 2020 •

edited

Loading

$@palaviv$ palaviv left a comment

$@palaviv$ palaviv Mar 27, 2020

$@coolreader18$ coolreader18 Mar 27, 2020

$@youknowone$ youknowone Mar 30, 2020 •

edited

Loading

$@coolreader18$ coolreader18 Mar 30, 2020

$@youknowone$ youknowone Mar 30, 2020