Fix unit test broken by GitHub Action image update - #2193
Merged
Conversation
Which now includes an AWS module with a conflicting completion.
Andy Jordan (andyleejordan)
marked this pull request as ready for review
October 29, 2024 18:55
Andy Jordan (andyleejordan)
requested a review
from Patrick Meinecke (SeeminglyScience)
October 29, 2024 18:56
Andy Jordan (andyleejordan)
enabled auto-merge
October 29, 2024 18:56
Patrick Meinecke (SeeminglyScience)
approved these changes
Oct 29, 2024
Patrick Meinecke (SeeminglyScience)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which now includes an AWS module with a conflicting completion (
AWS.Tools.SocialMessaging.psd1). Why GitHub Actions installed that, I don't know. Why our test made such a broad assumption, also unknown.