Switch VIM E2E tests to use nightly - #2183
Merged
Merged
Conversation
Justin Grote (JustinGrote)
marked this pull request as ready for review
October 2, 2024 01:14
Justin Grote (JustinGrote)
requested review from
Patrick Meinecke (SeeminglyScience) and
Andy Jordan (andyleejordan)
October 2, 2024 01:15
Justin Grote (JustinGrote)
enabled auto-merge
October 2, 2024 01:16
Justin Grote (JustinGrote)
force-pushed
the
JustinGrote/issue2182
branch
from
October 2, 2024 21:21
ff63f4b to
6d2ea99
Compare
Collaborator
Author
|
Rebased and ready. |
Andy Jordan (andyleejordan)
approved these changes
Oct 7, 2024
Andy Jordan (andyleejordan)
left a comment
Member
There was a problem hiding this comment.
Thanks Justin!
Justin Grote (JustinGrote)
added this pull request to the merge queue
Oct 7, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 7, 2024
Andy Jordan (andyleejordan)
added this pull request to the merge queue
Oct 7, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 7, 2024
Member
|
I wonder why it's passing in the PR but failing in the merge queue?! |
Member
|
Oh I can answer that. Only the merge queue installs and tests against PowerShell daily (since that takes a bit longer) and that's not currently working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current ubuntu2.19 package breaks E2E tests. Latest VIM works fine, so switching to nightly for testing.
Band-Aid for #2182 but will not close it as we should probably find out what in that 2.19 ubuntu security update broke it, as it is currently being distributed widely and we should make sure it hasn't broken ubuntu VIM users.