Add cert apis to enable certification auth. - #4
Closed
dyydj wants to merge 2 commits into
Closed
Conversation
added 2 commits
December 12, 2018 22:23
Summary: Add wrapping APIs for copy_cert_to_privkey. Test Plan: Reviewers: Subscribers: Tasks: Tags:
Member
|
Hi there, Thanks for the interest and PR!. Review in line. |
1 similar comment
Member
|
Hi there, Thanks for the interest and PR!. Review in line. |
pkittenis
requested changes
Aug 22, 2020
| c_ssh.ssh_string_free_char(_key) | ||
| return b_key | ||
|
|
||
| def copy_cert_to_privkey(self, SSHKey priv_key): |
Member
There was a problem hiding this comment.
This can probably better return a new private key, or at least make passing it in optional. Also needs a test, see existing import_* tests.
Suggested change
| def copy_cert_to_privkey(self, SSHKey priv_key): | |
| def copy_cert_to_privkey(self, SSHKey priv_key=None): | |
| <make and return new key if priv_key is None> |
| SSH_CLOSED_ERROR = c_ssh.SSH_CLOSED_ERROR | ||
| SSH_WRITE_PENDING = c_ssh.SSH_WRITE_PENDING | ||
|
|
||
| def libssh_init(): |
Member
There was a problem hiding this comment.
This is not a session function and should not be here. This is a top level libssh function, so probably should be in ssh/__init__.pyx.
Please also make a separate PR for adding these. According to libssh documentation, this function not needed to be called by users as of 0.8.0. Also needs libssh_destructor to be implemented and called if this is called by users.
Member
|
Stale and unfinished, re-doing from scratch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add wrapping APIs for copy_cert_to_privkey.