fix(pathfinder): use exact dynamic library names - #2689
Draft
rwgk wants to merge 2 commits into
Draft
Conversation
CUPTI uses the stable cupti64_13.dll basename starting with CUDA 13.5, so it no longer needs forward-compatible wildcard discovery for each toolkit release. Add the stable name and remove the now-unused Windows DLL fallback-glob metadata and search machinery.
Use one descriptor-defined newest-first candidate list for filesystem discovery, RTLD_NOLOAD checks, and native loading. Remove the generic unversioned and glob fallbacks so undeclared ABI names cannot be found on disk while remaining invisible to resident checks. Correct the cufftMp catalog ordering so ABI 12 is preferred over ABI 11. Layouts must provide an exact declared SONAME alias; physical patch filenames without that alias are intentionally not discovered.
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test ab26c96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related: #1732
cuda-pathfinderused broad filesystem wildcard matching for Linux sharedobjects and an explicit CUPTI fallback glob on Windows. Already-loaded
detection and native loading use descriptor-declared names instead, so a
wildcard-only match could load successfully but remain invisible to a later
uncached residency check. In less controlled cases, that asymmetry could also
allow a second version of a library into the process.
This PR simplifies and aligns the behavior:
platforms.
already-loaded detection, and native loading.
explicitly like other libraries.
11.
Explicit Linux filesystem layouts must now expose an exact declared SONAME
alias. A physical patch-version filename without that alias is intentionally
not discovered.
Checklist