Fix signal to callable connects - #364
Open
usiems wants to merge 3 commits into
Open
Conversation
as this seems to be the limit imposed by Qt. If we reach that number, wrap around and search for free slot ID. Also always call the callables on the thread that emitted the signal, and fix a potential thread safety issue. Fixes #362
or a signal/signal connect, if the argument is a signal object. Only if the argument is a regular callable create a new receiver object. This will change the behavior of connects with regard to threads in some cases! Fixed #363 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
usiems
force-pushed
the
fix_signal_to_callable_connects
branch
from
August 21, 2026 14:14
e241e72 to
100cb30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally this was only meant to fix #362, but then I noticed that a test in our MeVisLab code base failed after the change because of a faulty assumption regarding connections to user-created slots, and so I entered issue #363 and fixed that, too.
I must admit that I am a little bit uneasy about this change, because with these changes the type of connection used (and the target object) depends on factors that are not readily apparent, while before there could be misconceptions about the targeted object in the connect.
I'm open to suggestions.
It is probably advisable to review the commits separately.