Skip to content

feat: add support SELECT all columns from function result - #2207

Merged
manticore-projects merged 1 commit into
JSQLParser:masterfrom
0xlianhu:lian-support-select-all-columns-from-function-result
Mar 26, 2025
Merged

feat: add support SELECT all columns from function result#2207
manticore-projects merged 1 commit into
JSQLParser:masterfrom
0xlianhu:lian-support-select-all-columns-from-function-result

Conversation

@0xlianhu

@0xlianhu 0xlianhu commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

PostgreSQL supports composite type expansion using .*, for example, below query is valid in PostgreSQL:

SELECT (pg_stat_file('postgresql.conf')).*

More generic one is like below one in queries or sub-queries:

SELECT (function_name(param1, ... paramN)).* FROM my_table ...

There might be multiple duplicated parentheses surround the function call, such as:

SELECT (((pg_stat_file('postgresql.conf')))).* -- this is same effect as one `()` surrounding

The PR is adding the support to parse/deparse this type of SQLs.

PostgreSQL supports composite type expansion using .*,
for example below query is valid in PostgreSQL:
SELECT (pg_stat_file('postgresql.conf')).*
@manticore-projects

Copy link
Copy Markdown
Contributor

Beautifully executed! Well done and thank you much for your effort and contribution.

@manticore-projects
manticore-projects merged commit 30cf5d7 into JSQLParser:master Mar 26, 2025
@manticore-projects

Copy link
Copy Markdown
Contributor

Greetings!

Unfortunately, I found out that commit 30cf5d7 causes a huge performance deterioration:

(version)  Mode  Cnt    Score    Error  Units
   latest  avgt    3   81.637 ± 21.386  ms/op <-- `FunctionAllColumns()` commented out
      5.2  avgt    3  393.523 ± 54.199  ms/op <-- release w/ `FunctionAllColumns()`
      5.1  avgt    3   86.419 ± 22.178  ms/op <-- release w/o `FunctionAllColumns()`

This toll is not acceptable for a rather exotic feature only and I am going to disable it.
Although all code is still there and only the call of FunctionAllColumns() in PrimaryExpression has been commented out.

You are welcome to refactor your code and I will most happily accept it again once performance can be proved.

Recommendations:

  1. try to avoid the syntactic Lookahead
  2. your (((( FUNCTION )))).* is nothing else but a ParenthesedExpressionList with just one parameter of type Function, followed by ".". So maybe parse for a possible extension by "." at the end of a ParenthesedExpressionList when it has only one single Function element.

I am open for discussion of course.
Best and cheers!

manticore-projects added a commit that referenced this pull request May 13, 2025
- optimise the `LOOKAHEAD`, avoid syntactic lookaheads

- disable `FunctionAllColumns()` in `PrimaryExpression` related to #2207

Signed-off-by: Andreas Reichel <andreas@manticore-projects.com>
manticore-projects pushed a commit that referenced this pull request Aug 13, 2026
PostgreSQL expands a composite-returning function call into its columns with
(function_call).*, e.g. SELECT (json_populate_record(NULL::users, data)).*
FROM staging_users. JSQLParser rejected the trailing .* .

Composite row expansion was implemented in #2207 but afterwards disabled,
because the speculative syntactic LOOKAHEAD(FunctionAllColumns()) at the
PrimaryExpression entry caused a severe regression (393 ms/op vs ~86 ms/op).
The AST node, deparser, validator and all visitors stayed in place; only the
grammar call site was commented out.

Re-enable the feature without the speculative lookahead: after a
ParenthesedExpressionList wrapping a single Function is parsed, a bounded
semantic follower check (isFunctionAllColumnsAhead) peeks .* and wraps the
result into FunctionAllColumns. The check first compares the next two tokens
and only then unwraps the already-parsed expression, so the common path (a
parenthesised expression not followed by .*) bails out in two comparisons
without any speculative production or backtracking. TablesNamesFinder now
descends into the wrapped function so column/table references inside the
expansion are not lost.

Scope: only (function_call).* is supported; arbitrary (non-function
expression).* remains unsupported and fails cleanly as before. Redundant
surrounding parentheses are unwrapped to the inner function.

Performance (gradle jmh, parseSQLStatements on performance.sql, version=latest,
10 forks x 10 iterations, 100 samples, dedicated 32-core host):
  master (disabled): 3.632 +/- 0.020 ms/op
  this change:       3.639 +/- 0.023 ms/op
The +0.19% delta lies within the confidence intervals and is far from the
393 ms/op toll that motivated disabling the feature.

Testing: CompositeRowExpansionTest covers the issue case, simple and no-arg
functions, the INSERT...SELECT use case, multiple surrounding parentheses,
and negative cases (no trailing .*, RowGet expression, non-function
expression). The positive tests fail on master and pass with this change.

Fixes #2412

Signed-off-by: 付典 <fudianchn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants