From 8637b223a77fdee3993d79361dafeed403c210ef Mon Sep 17 00:00:00 2001 From: Jannik Hollenbach Date: Tue, 19 Nov 2019 12:50:17 +0100 Subject: [PATCH 1/4] Move SSH Scan Test Target to www.iteratec.de securecodebox.io doesn't have a ssh port open anymore since we moved over to github pages ;) --- test/ssh.test.js | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/test/ssh.test.js b/test/ssh.test.js index d8807c37db..bba41f7870 100644 --- a/test/ssh.test.js +++ b/test/ssh.test.js @@ -1,15 +1,15 @@ const { startSecurityTest, Time } = require('./sdk'); test( - 'finds a few low severity findigns for securecodebox.io', + 'finds a few low severity findings for securecodebox.io', async () => { const securityTest = await startSecurityTest({ - context: 'securecodebox.io tls', + context: 'www.iteratec.de ssh', metaData: {}, name: 'ssh', target: { - name: 'securecodebox.io tls', - location: 'securecodebox.io', + name: 'www.iteratec.de ssh', + location: 'www.iteratec.de', attributes: {}, }, }); @@ -36,16 +36,8 @@ test( expect(findings).toContainEqual({ category: 'SSH Policy Violation', - description: 'Deprecated / discouraged SSH key algorithms are used', - name: 'Insecure SSH Key Algorithms', - osi_layer: 'NETWORK', - severity: 'MEDIUM', - }); - - expect(findings).toContainEqual({ - category: 'SSH Policy Violation', - description: 'Deprecated / discouraged SSH MAC algorithms are used', - name: 'Insecure SSH MAC Algorithms', + description: 'Discouraged SSH authentication methods are used', + name: 'Discouraged SSH authentication methods', osi_layer: 'NETWORK', severity: 'MEDIUM', }); @@ -53,8 +45,7 @@ test( expect( findings .filter(({ name }) => name !== 'SSH Service Information') - .filter(({ name }) => name !== 'Insecure SSH Key Algorithms') - .filter(({ name }) => name !== 'Insecure SSH MAC Algorithms') + .filter(({ name }) => name !== 'Discouraged SSH authentication methods') ).toEqual([]); }, 2 * Time.Minute From be70a4ee06717cd57740547937524666b5bd5b0e Mon Sep 17 00:00:00 2001 From: Jannik Hollenbach Date: Tue, 19 Nov 2019 13:44:38 +0100 Subject: [PATCH 2/4] Adjust sslyze findings to the new website --- test/sslyze.test.js | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/test/sslyze.test.js b/test/sslyze.test.js index e3a8abf093..dd3c83ad66 100644 --- a/test/sslyze.test.js +++ b/test/sslyze.test.js @@ -52,16 +52,6 @@ test( category: 'Resumption', severity: 'INFORMATIONAL', }); - expect(findings).toContainEqual({ - name: 'TLSv1 supported', - category: 'TLSv1', - severity: 'LOW', - }); - expect(findings).toContainEqual({ - name: 'TLSv1.1 supported', - category: 'TLSv1.1', - severity: 'INFORMATIONAL', - }); expect(findings).toContainEqual({ name: 'TLSv1.2 supported', category: 'TLSv1.2', From 322224e856298fb94be17d1028ce810ac942477f Mon Sep 17 00:00:00 2001 From: Jannik Hollenbach Date: Tue, 19 Nov 2019 14:19:54 +0100 Subject: [PATCH 3/4] Configure eslint to match existing style --- test/.eslintrc | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 test/.eslintrc diff --git a/test/.eslintrc b/test/.eslintrc new file mode 100644 index 0000000000..9b17d289f2 --- /dev/null +++ b/test/.eslintrc @@ -0,0 +1,5 @@ +{ + "rules": { + "quotes": ["warn", "single"] + } +} From e164c95bb541a592f9f028ee538d8e600b8b7096 Mon Sep 17 00:00:00 2001 From: Jannik Hollenbach Date: Tue, 19 Nov 2019 14:20:57 +0100 Subject: [PATCH 4/4] Remove unexpected undefined --- test/ssh.test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/ssh.test.js b/test/ssh.test.js index bba41f7870..4d37191bba 100644 --- a/test/ssh.test.js +++ b/test/ssh.test.js @@ -28,7 +28,6 @@ test( expect(findings).toContainEqual({ category: 'SSH Service', - description: undefined, name: 'SSH Service Information', osi_layer: 'NETWORK', severity: 'INFORMATIONAL',