Skip to content

Commit a90eb23

Browse files
JohnVillalovosJohnVillalovos
committed
chore: fix pylint error "expression-not-assigned"
Fix pylint error "expression-not-assigned" and remove check from the disabled list. And I personally think it is much more readable now and is less lines of code.
1 parent 3a7d6f6 commit a90eb23

2 files changed

Lines changed: 20 additions & 29 deletions

File tree

‎gitlab/v4/cli.py‎

Lines changed: 20 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -266,20 +266,16 @@ def _populate_sub_parser_by_class(
266266
sub_parser_action.add_argument(f"--{id_attr}", required=True)
267267

268268
required, optional, dummy = cli.custom_actions[name][action_name]
269-
[
270-
sub_parser_action.add_argument(
271-
f"--{x.replace('_', '-')}", required=True
272-
)
273-
for x in required
274-
if x != cls._id_attr
275-
]
276-
[
277-
sub_parser_action.add_argument(
278-
f"--{x.replace('_', '-')}", required=False
279-
)
280-
for x in optional
281-
if x != cls._id_attr
282-
]
269+
for x in required:
270+
if x != cls._id_attr:
271+
sub_parser_action.add_argument(
272+
f"--{x.replace('_', '-')}", required=True
273+
)
274+
for x in optional:
275+
if x != cls._id_attr:
276+
sub_parser_action.add_argument(
277+
f"--{x.replace('_', '-')}", required=False
278+
)
283279

284280
if mgr_cls.__name__ in cli.custom_actions:
285281
name = mgr_cls.__name__
@@ -293,20 +289,16 @@ def _populate_sub_parser_by_class(
293289
sub_parser_action.add_argument("--sudo", required=False)
294290

295291
required, optional, dummy = cli.custom_actions[name][action_name]
296-
[
297-
sub_parser_action.add_argument(
298-
f"--{x.replace('_', '-')}", required=True
299-
)
300-
for x in required
301-
if x != cls._id_attr
302-
]
303-
[
304-
sub_parser_action.add_argument(
305-
f"--{x.replace('_', '-')}", required=False
306-
)
307-
for x in optional
308-
if x != cls._id_attr
309-
]
292+
for x in required:
293+
if x != cls._id_attr:
294+
sub_parser_action.add_argument(
295+
f"--{x.replace('_', '-')}", required=True
296+
)
297+
for x in optional:
298+
if x != cls._id_attr:
299+
sub_parser_action.add_argument(
300+
f"--{x.replace('_', '-')}", required=False
301+
)
310302

311303

312304
def extend_parser(parser: argparse.ArgumentParser) -> argparse.ArgumentParser:

‎pyproject.toml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ disable = [
5555
"consider-using-sys-exit",
5656
"cyclic-import",
5757
"duplicate-code",
58-
"expression-not-assigned",
5958
"fixme",
6059
"implicit-str-concat",
6160
"import-outside-toplevel",

0 commit comments

Comments
 (0)