Java: Create new query Cleartext storage of sensitive information in Android filesystem - #6576
Merged
atorralba merged 8 commits intoJan 17, 2022
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a query that detects sensitive information being stored in the Android filesystem without encryption, which may expose it to attackers or malicious applications.
The query looks for sensitive data flowing into file inputs that isn't sanitized by encryption or hashing methods. Said methods are currently detected with a simple heuristic - there's field for improvement there.
This PR also adds a little modeling (sinks) for creating and writing to files using the JDK. The
create-filesinks were moved fromExternalFlow.qllto their own library (Files.qll).Evaluation
TO DO