From 5435eabb10595c7b0696a733ff43d1e3709363f6 Mon Sep 17 00:00:00 2001 From: abdulfrfr Date: Mon, 3 Oct 2022 22:37:36 +0100 Subject: [PATCH 1/3] modified the CONTRIBUTION.md file, i had issues with trying to run and test some codes and i found out that i needed to run and install jest from npm first, i did and it worked --- CONTRIBUTING.md | 5 +++++ package-lock.json | 2 +- package.json | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d54c7472cd..02d15ece97 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -83,6 +83,11 @@ and inspect the outcome. Example: [RatInAMaze.test.js](Backtracking/tests/RatInA Please refrain from using `console` in your implementation AND test code. You can (and should!) run all tests locally before committing your changes: +You may also want to install jest from npm before running your test: + +```shell +npm i jest +``` ```shell npm test diff --git a/package-lock.json b/package-lock.json index d7cb0da2ee..d3f4600666 100644 --- a/package-lock.json +++ b/package-lock.json @@ -23,7 +23,7 @@ "babel-jest": "^26.3.0", "globby": "^12.0.2", "husky": "^7.0.4", - "jest": "^26.4.2", + "jest": "^26.6.3", "standard": "^16.0.4" }, "engines": { diff --git a/package.json b/package.json index 8ba035922c..f7865aebec 100644 --- a/package.json +++ b/package.json @@ -32,7 +32,7 @@ "babel-jest": "^26.3.0", "globby": "^12.0.2", "husky": "^7.0.4", - "jest": "^26.4.2", + "jest": "^26.6.3", "standard": "^16.0.4" }, "engines": { From 7c930834e6b13494b023e896109b1570c2a9302b Mon Sep 17 00:00:00 2001 From: abdulfrfr Date: Wed, 5 Oct 2022 10:32:34 +0100 Subject: [PATCH 2/3] recommend installation of all deps using npm install --- CONTRIBUTING.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 02d15ece97..006e918b52 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -82,13 +82,14 @@ and inspect the outcome. Example: [RatInAMaze.test.js](Backtracking/tests/RatInA Please refrain from using `console` in your implementation AND test code. -You can (and should!) run all tests locally before committing your changes: -You may also want to install jest from npm before running your test: +First it is recommended of you to install all dependencies using: ```shell -npm i jest +npm install ``` +You can (and should!) run all tests locally before committing your changes: + ```shell npm test ``` From e7cae545b2e9723f29c1acd19c49870bada88295 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20M=C3=BCller?= <34514239+appgurueu@users.noreply.github.com> Date: Thu, 6 Oct 2022 12:14:07 +0200 Subject: [PATCH 3/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 006e918b52..cff019deba 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -82,7 +82,7 @@ and inspect the outcome. Example: [RatInAMaze.test.js](Backtracking/tests/RatInA Please refrain from using `console` in your implementation AND test code. -First it is recommended of you to install all dependencies using: +First you should install all dependencies using: ```shell npm install