API 6.3 for V13 - #3392
Merged
Merged
Conversation
Bibo-Joshi
requested changes
Nov 25, 2022
Bibo-Joshi
left a comment
Member
There was a problem hiding this comment.
I admire your patience with v13!
harshil21
reviewed
Nov 26, 2022
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
This reverts commit 6c156a1.
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Bibo-Joshi
approved these changes
Dec 4, 2022
Member
There was a problem hiding this comment.
TBH I didn't go through all changed lines again and also didn't read every single test, but my previous comments where addressed nicely and everything looks in order :) LGTM! Thanks for the PR, Pool!
PS: I'm going to ignore DS on v13 and codacy just complains about this branch not being analyzed - which is fine with me, since it will die soon π₯³
harshil21
approved these changes
Dec 4, 2022
harshil21
left a comment
Member
There was a problem hiding this comment.
I also did have a rough look at it, and it looks good to me as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently not implemented are the changed/new tests.
I already implemented #3381, if there was another fix related to the 6.3 changes from #3346 I missed that.