Skip to content

Add tox -e cog to update README tables - #313

Merged
JulienPalard merged 5 commits into
python:mainfrom
hugovk:cog
Oct 17, 2025
Merged

Add tox -e cog to update README tables#313
JulienPalard merged 5 commits into
python:mainfrom
hugovk:cog

Conversation

@hugovk

@hugovk hugovk commented Sep 8, 2025

Copy link
Copy Markdown
Member

Also output the tables in GitHub-flavoured Markdown instead of RST, because it's README.md.

And remove the irrelevant Travis CI column, we've not used it for years and .travis.yml was deleted in 2021: python/cpython#30257

hugovk
hugovk commented Sep 8, 2025
View reviewed changes
Comment thread tox.ini
{posargs}

[testenv:cog]
base_python = python3.13

@hugovk hugovk Sep 8, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use 3.14 yet because one transitive dependency is pydantic, which doesn't yet support 3.14.

They added initial support in pydantic/pydantic#11613 and have released an alpha, but we're waiting for a final release of pydantic 2.12.

AA-Turner
AA-Turner requested changes Sep 8, 2025
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a rather heavy dependency for an infrequent task that isn't that much of a hardship:

cog v0.16.6
β”œβ”€β”€ attrs v23.2.0
β”œβ”€β”€ fastapi v0.115.14
β”‚   β”œβ”€β”€ pydantic v2.11.7
β”‚   β”‚   β”œβ”€β”€ annotated-types v0.7.0
β”‚   β”‚   β”œβ”€β”€ pydantic-core v2.33.2
β”‚   β”‚   β”‚   └── typing-extensions v4.15.0
β”‚   β”‚   β”œβ”€β”€ typing-extensions v4.15.0
β”‚   β”‚   └── typing-inspection v0.4.1
β”‚   β”‚       └── typing-extensions v4.15.0
β”‚   β”œβ”€β”€ starlette v0.46.2
β”‚   β”‚   └── anyio v4.10.0
β”‚   β”‚       β”œβ”€β”€ idna v3.10
β”‚   β”‚       └── sniffio v1.3.1
β”‚   └── typing-extensions v4.15.0
β”œβ”€β”€ pydantic v2.11.7 (*)
β”œβ”€β”€ pyyaml v6.0.2
β”œβ”€β”€ requests v2.32.5
β”‚   β”œβ”€β”€ certifi v2025.8.3
β”‚   β”œβ”€β”€ charset-normalizer v3.4.3
β”‚   β”œβ”€β”€ idna v3.10
β”‚   └── urllib3 v2.5.0
β”œβ”€β”€ structlog v24.4.0
β”œβ”€β”€ typing-extensions v4.15.0
└── uvicorn v0.35.0
    β”œβ”€β”€ click v8.2.1
    β”‚   └── colorama v0.4.6
    └── h11 v0.16.0

I'd be fine with using GFM tables (though they're rather verbose in the source), but I don't think we need the other changes in this PR.

A

@hugovk

hugovk commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

Good point, I've moved the cog dependency out of tools_requirements.txt, so it's only installed when running tox.

m-aciek
m-aciek approved these changes Oct 1, 2025
View reviewed changes

@m-aciek m-aciek left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Looks good to me πŸ‘

I like cog for locality of behaviour.

JulienPalard
JulienPalard reviewed Oct 16, 2025
View reviewed changes
Comment thread tox.ini Outdated
@JulienPalard
JulienPalard merged commit c08754f into python:main Oct 17, 2025
10 checks passed
@JulienPalard

JulienPalard commented Oct 17, 2025

Copy link
Copy Markdown
Member

Thanks @hugovk! I've heard of cog once, it's the first time I see a use of it, that's interesting :)))

@hugovk
hugovk deleted the cog branch October 17, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard left review comments
@AA-Turner AA-Turner AA-Turner requested changes
+1 more reviewer
@m-aciek m-aciek m-aciek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugovk @JulienPalard @AA-Turner @m-aciek