Skip to content

Stop using deprecated logging API in Sphinx - #9875

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:fix_sphinx
Oct 15, 2018
Merged

Stop using deprecated logging API in Sphinx#9875
pablogsal merged 1 commit into
python:masterfrom
pablogsal:fix_sphinx

Conversation

@pablogsal

@pablogsal pablogsal commented Oct 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

The doc target can fail due to the use of a deprecated logging API in
Doc/tools/extensions/suspicious.py and treating warnings as errors. Example error:

$ make check suspicious html SPHINXOPTS="-q -W -j4"
python3 tools/rstlint.py -i tools -i ./venv -i README.rst
No problems found.
make[1]: Entering directory `/home/travis/build/python/cpython/Doc'
mkdir -p build
Building NEWS from Misc/NEWS.d with blurb
PATH=./venv/bin:$PATH sphinx-build -b suspicious -d build/doctrees -D latex_elements.papersize= -q -W -j4 . build/suspicious 
/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/sphinx/application.py:402: RemovedInSphinx20Warning: app.info() is now deprecated. Use sphinx.util.logging instead.
  RemovedInSphinx20Warning)

@pablogsal
pablogsal merged commit ee171a2 into python:master Oct 15, 2018
@pablogsal
pablogsal deleted the fix_sphinx branch October 15, 2018 19:07
vstinner added a commit that referenced this pull request Oct 16, 2018
@vstinner
Revert "Stop using deprecated logging API in Sphinx suspicious checker (
0f4cec0 
GH-9875)"

This reverts commit ee171a2.
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Oct 18, 2018
@CuriousLearner
Merge branch 'master' into fix-issue8525
c0917e3 
* master: (621 commits)
  Update opcode.h header comment to mention the source data file (pythonGH-9935)
  bpo-34936: Fix TclError in tkinter.Spinbox.selection_element(). (pythonGH-9760)
  Updated documentation on logging.debug(). (pythonGH-9946)
  bpo-34765: Update the install-sh file (pythonGH-9592)
  bpo-35008: Fix possible leaks in Element.__setstate__(). (pythonGH-9924)
  bpo-35011: Restore use of pyexpatns.h in libexpat (pythonGH-9939)
  bpo-24658: Fix read/write greater than 2 GiB on macOS (pythonGH-1705)
  Add missing comma to wsgiref doc (pythonGH-9932)
  bpo-23420: Verify the value of '-s' when execute the CLI of cProfile (pythonGH-9925)
  Doc: Fix is_prime (pythonGH-9909)
  In email docs, correct spelling of foregoing (python#9856)
  In email.parser in message_from_bytes, update `strict` to `policy` (python#9854)
  bpo-34997: Fix test_logging.ConfigDictTest.test_out_of_order (pythonGH-9913)
  Added CLI starter example to logging cookbook. (pythonGH-9910)
  bpo-34783: Fix test_nonexisting_script() (pythonGH-9896)
  bpo-23554: Change echo server example class name from EchoServerClientProtocol to EchoServerProtocol (pythonGH-9859)
  bpo-34989: python-gdb.py: fix current_line_num() (pythonGH-9889)
  Stop using deprecated logging API in Sphinx suspicious checker (pythonGH-9875)
  fix dangling keyfunc examples in documentation of heapq and sorted (python#1432)
  bpo-34844: logging.Formatter enhancement - Ensure style and format string matches in logging.Formatter  (pythonGH-9703)
  ...
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Oct 18, 2018
@CuriousLearner
Merge branch 'master' into fix-issue15045
9f75617 
* master: (1787 commits)
  Update opcode.h header comment to mention the source data file (pythonGH-9935)
  bpo-34936: Fix TclError in tkinter.Spinbox.selection_element(). (pythonGH-9760)
  Updated documentation on logging.debug(). (pythonGH-9946)
  bpo-34765: Update the install-sh file (pythonGH-9592)
  bpo-35008: Fix possible leaks in Element.__setstate__(). (pythonGH-9924)
  bpo-35011: Restore use of pyexpatns.h in libexpat (pythonGH-9939)
  bpo-24658: Fix read/write greater than 2 GiB on macOS (pythonGH-1705)
  Add missing comma to wsgiref doc (pythonGH-9932)
  bpo-23420: Verify the value of '-s' when execute the CLI of cProfile (pythonGH-9925)
  Doc: Fix is_prime (pythonGH-9909)
  In email docs, correct spelling of foregoing (python#9856)
  In email.parser in message_from_bytes, update `strict` to `policy` (python#9854)
  bpo-34997: Fix test_logging.ConfigDictTest.test_out_of_order (pythonGH-9913)
  Added CLI starter example to logging cookbook. (pythonGH-9910)
  bpo-34783: Fix test_nonexisting_script() (pythonGH-9896)
  bpo-23554: Change echo server example class name from EchoServerClientProtocol to EchoServerProtocol (pythonGH-9859)
  bpo-34989: python-gdb.py: fix current_line_num() (pythonGH-9889)
  Stop using deprecated logging API in Sphinx suspicious checker (pythonGH-9875)
  fix dangling keyfunc examples in documentation of heapq and sorted (python#1432)
  bpo-34844: logging.Formatter enhancement - Ensure style and format string matches in logging.Formatter  (pythonGH-9703)
  ...
@miss-islington

miss-islington commented Jun 9, 2019

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR ๐ŸŒฎ๐ŸŽ‰.. I'm working now to backport this PR to: 3.6.
๐Ÿ๐Ÿ’โ›๐Ÿค–

@miss-islington

miss-islington commented Jun 9, 2019

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR ๐ŸŒฎ๐ŸŽ‰.. I'm working now to backport this PR to: 3.7.
๐Ÿ๐Ÿ’โ›๐Ÿค–

@bedevere-bot

bedevere-bot commented Jun 9, 2019

Copy link
Copy Markdown

GH-13923 is a backport of this pull request to the 3.6 branch.

@bedevere-bot

bedevere-bot commented Jun 9, 2019

Copy link
Copy Markdown

GH-13924 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2019
@pablogsal @miss-islington
Stop using deprecated logging API in Sphinx suspicious checker (pythoโ€ฆ
39ffa42 
โ€ฆnGH-9875)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2019
@pablogsal @miss-islington
Stop using deprecated logging API in Sphinx suspicious checker (pythoโ€ฆ
8d9e4ea 
โ€ฆnGH-9875)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@miss-islington

miss-islington commented Jun 9, 2019

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR ๐ŸŒฎ๐ŸŽ‰.. I'm working now to backport this PR to: 2.7.
๐Ÿ๐Ÿ’โ›๐Ÿค–

@bedevere-bot

bedevere-bot commented Jun 9, 2019

Copy link
Copy Markdown

GH-13925 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2019
@pablogsal @miss-islington
Stop using deprecated logging API in Sphinx suspicious checker (pythoโ€ฆ
9837e9b 
โ€ฆnGH-9875)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Jun 9, 2019
@miss-islington @pablogsal
Stop using deprecated logging API in Sphinx suspicious checker (GH-9875)
3621bf2 
(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
ned-deily pushed a commit that referenced this pull request Jun 9, 2019
@miss-islington @pablogsal @ned-deily
Stop using deprecated logging API in Sphinx suspicious checker (GH-9875โ€ฆ
9393e19 
โ€ฆ) (GH-13923)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@miss-islington

miss-islington commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR ๐ŸŒฎ๐ŸŽ‰.. I'm working now to backport this PR to: 2.7.
๐Ÿ๐Ÿ’โ›๐Ÿค–

@miss-islington

miss-islington commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

Sorry @pablogsal, I had trouble checking out the 2.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ee171a26c1169abfae534b08acc0d95c6e45a22a 2.7

benjaminp pushed a commit that referenced this pull request Oct 8, 2019
@pablogsal @benjaminp
[2.7] Stop using deprecated logging API in Sphinx suspicious checker (Gโ€ฆ
86971d4 
โ€ฆH-9875)

(cherry picked from commit ee171a2)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@JulienPalard JulienPalard Awaiting requested review from JulienPalard

Assignees

@pablogsal pablogsal

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pablogsal @miss-islington @bedevere-bot @brettcannon @benjaminp @ned-deily @the-knights-who-say-ni