GH-155728: Untrack const tuples - #156419
Open
sergey-miryanov wants to merge 4 commits into
Open
Conversation
- both used in flowgraph optimizations
sergey-miryanov
requested review from
Eclips4,
iritkatriel and
markshannon
as code owners
August 26, 2026 14:25
sergey-miryanov
commented
Aug 26, 2026
| } | ||
| PyTuple_SET_ITEM(const_tuple, i, element); | ||
| } | ||
| _PyTuple_MaybeUntrack(const_tuple); |
Contributor
Author
There was a problem hiding this comment.
We could avoid a second pass there, just like in marshal, by checking each element. But I'm not sure we should do it, since it adds a bit of complexity.
I'm open to change this, if it is worth.
Member
There was a problem hiding this comment.
IMO, we should do the same logic in each case, because we don't want to expose partially constructed tuples to the GC.
@markshannon, WDYT?
Contributor
Author
There was a problem hiding this comment.
Good point, will fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.