[3.15] gh-155648: Fix IDLE tests that cannot fail (GH-156257) - #156315
Merged
Conversation
test_autocomplete.py:241 passes when proper because any([]) is True is true. It would also pass if small only had underscored words because the filter got reversed. Change logic and replace filter with generator expression
using slice instead of startswith. Change line 242 to match.
test_editor.py:236 and test_configdialog.py:55 have empty tests ('pass'); skip them for now.
PR-pythonGH-156260 add real tests.
template.py:25 tests True == True; skip it. With this, the bug scanner should be satisfied while allowing
setUpClass and tearDownClass to run and be verified.
Remove duplicate and confusing fetch_completions call.
(cherry picked from commit ee1da7e)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy
approved these changes
Aug 24, 2026
terryjreedy
left a comment
Member
There was a problem hiding this comment.
Patch reviewed and approved after changes by Serhiy on main PR.
serhiy-storchaka
approved these changes
Aug 24, 2026
terryjreedy
approved these changes
Aug 25, 2026
terryjreedy
left a comment
Member
There was a problem hiding this comment.
Patch reviewed and approved after changes by Serhiy on main PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_autocomplete.py:241 passes when proper because any([]) is True is true. It would also pass if small only had underscored words because the filter got reversed. Change logic and replace filter with generator expression
using slice instead of startswith. Change line 242 to match.
test_editor.py:236 and test_configdialog.py:55 have empty tests ('pass'); skip them for now.
PR-GH-156260 add real tests.
template.py:25 tests True == True; skip it. With this, the bug scanner should be satisfied while allowing
setUpClass and tearDownClass to run and be verified.
Remove duplicate and confusing fetch_completions call.
(cherry picked from commit ee1da7e)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu