Skip to content

#1724 random min max 과제 λ²ˆμ—­11λ²ˆμ§Έμ€„ - #1727

Merged
Violet-Bora-Lee merged 1 commit into
javascript-tutorial:masterfrom
ArtistGodGun:1724-random-min-max-task-11
Dec 1, 2023
Merged

#1724 random min max 과제 λ²ˆμ—­11λ²ˆμ§Έμ€„#1727
Violet-Bora-Lee merged 1 commit into
javascript-tutorial:masterfrom
ArtistGodGun:1724-random-min-max-task-11

Conversation

@ArtistGodGun

@ArtistGodGun ArtistGodGun commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

μš”μ•½

μ—°κ΄€ 이슈

#1724

Pull Request 체크리슀트

TODO

  • λ²ˆμ—­ κ·œμΉ™μ„ ν™•μΈν•˜μ…¨λ‚˜μš”?
    • 쀄 λ°”κΏˆκ³Ό 단락을 '원문과 λ™μΌν•˜κ²Œ' μœ μ§€ν•˜μ…¨λ‚˜μš”?
    • λ§žμΆ€λ²• κ²€μ‚¬κΈ°λ‘œ λ§žμΆ€λ²•μ„ ν™•μΈν•˜μ…¨λ‚˜μš”?
    • λ§ˆν¬λ‹€μš΄ 문법에 μ‚¬μš©λ˜λŠ” 곡백(슀페이슀), ν°λ”°μ˜΄ν‘œ("), μž‘μ€λ”°μ˜΄ν‘œ('), λŒ€μ‹œ(-), λ°±ν‹±(`) λ“±μ˜ νŠΉμˆ˜λ¬ΈμžλŠ” κ·ΈλŒ€λ‘œ λ‘μ…¨λ‚˜μš”?
  • 둜컬 μ„œλ²„ μ„ΈνŒ… ν›„ μ΅œμ’… 결과물을 확인해 λ³΄μ…¨λ‚˜μš”?
  • PR ν•˜λ‚˜μ—” λ²ˆμ—­λ¬Έ ν•˜λ‚˜λ§Œ λ„£μœΌμ…¨λ‚˜μš”?
  • 의미 μžˆλŠ” 컀밋 λ©”μ‹œμ§€λ₯Ό μž‘μ„±ν•˜μ…¨λ‚˜μš”?
    • μ˜ˆμ‹œ
      • [ν”„λ½μ‹œ] λ²ˆμ—­
      • [ν”„λ½μ‹œ] 과제 λ²ˆμ—­
      • [ifλ¬Έκ³Ό 쑰건뢀 μ—°μ‚°μž '?'] 리뷰
      • [주석] 2μ°¨ 리뷰
      • [Date 객체와 λ‚ μ§œ] λ²ˆμ—­

@CLAassistant

CLAassistant commented Dec 1, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ArtistGodGun ArtistGodGun reopened this Dec 1, 2023

@Violet-Bora-Lee Violet-Bora-Lee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ‘
(Looks Good To Me)

@Violet-Bora-Lee
Violet-Bora-Lee merged commit 7230399 into javascript-tutorial:master Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants