Skip to content

Commit 8bcdef8

Browse files
committed
wip
1 parent 0ab88da commit 8bcdef8

5 files changed

Lines changed: 0 additions & 21 deletions

File tree

src/main/java/graphql/Profiler.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,6 @@ default void oldStrategyDispatchingAll(int level) {
4242

4343
}
4444

45-
default void chainedStrategyDispatching(int level) {
46-
47-
}
48-
4945
default void batchLoadedOldStrategy(String name, int level, int count) {
5046

5147

src/main/java/graphql/ProfilerImpl.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,6 @@ public void dataLoaderUsed(String dataLoaderName) {
126126
profilerResult.addDataLoaderUsed(dataLoaderName);
127127
}
128128

129-
@Override
130-
public void chainedStrategyDispatching(int level) {
131-
profilerResult.chainedStrategyDispatching(level);
132-
}
133-
134129
@Override
135130
public void oldStrategyDispatchingAll(int level) {
136131
profilerResult.oldStrategyDispatchingAll(level);

src/main/java/graphql/ProfilerResult.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ public class ProfilerResult {
3939
private volatile Operation operationType;
4040
private volatile boolean dataLoaderChainingEnabled;
4141
private final Set<Integer> oldStrategyDispatchingAll = ConcurrentHashMap.newKeySet();
42-
private final Set<Integer> chainedStrategyDispatching = ConcurrentHashMap.newKeySet();
4342

4443
private final List<String> instrumentationClasses = Collections.synchronizedList(new ArrayList<>());
4544

@@ -172,9 +171,6 @@ void oldStrategyDispatchingAll(int level) {
172171
}
173172

174173

175-
void chainedStrategyDispatching(int level) {
176-
chainedStrategyDispatching.add(level);
177-
}
178174

179175
void addDispatchEvent(String dataLoaderName, @Nullable Integer level, int count, DispatchEventType type) {
180176
dispatchEvents.add(new DispatchEvent(dataLoaderName, level, count, type));
@@ -251,9 +247,6 @@ public Map<String, Integer> getDataLoaderLoadInvocations() {
251247
return dataLoaderLoadInvocations;
252248
}
253249

254-
public Set<Integer> getChainedStrategyDispatching() {
255-
return chainedStrategyDispatching;
256-
}
257250

258251
public Set<Integer> getOldStrategyDispatchingAll() {
259252
return oldStrategyDispatchingAll;
@@ -288,7 +281,6 @@ public String fullSummary() {
288281
", dataLoaderChainingEnabled=" + dataLoaderChainingEnabled +
289282
", dataLoaderLoadInvocations=" + dataLoaderLoadInvocations +
290283
", oldStrategyDispatchingAll=" + oldStrategyDispatchingAll +
291-
", chainedStrategyDispatching=" + chainedStrategyDispatching +
292284
", dispatchEvents=" + printDispatchEvents() +
293285
'}';
294286
}
@@ -307,7 +299,6 @@ public String shortSummary() {
307299
", dataLoaderChainingEnabled=" + dataLoaderChainingEnabled +
308300
", dataLoaderLoadInvocations=" + dataLoaderLoadInvocations +
309301
", oldStrategyDispatchingAll=" + oldStrategyDispatchingAll +
310-
", chainedStrategyDispatching=" + chainedStrategyDispatching +
311302
", dispatchEvents=" + printDispatchEvents() +
312303
'}';
313304

@@ -328,7 +319,6 @@ public Map<String, Object> shortSummaryMap() {
328319
result.put("dataLoaderChainingEnabled", dataLoaderChainingEnabled);
329320
result.put("dataLoaderLoadInvocations", dataLoaderLoadInvocations);
330321
result.put("oldStrategyDispatchingAll", oldStrategyDispatchingAll);
331-
result.put("chainedStrategyDispatching", chainedStrategyDispatching);
332322
result.put("dispatchEvents", getDispatchEventsAsMap());
333323
result.put("instrumentationClasses", instrumentationClasses);
334324
return result;

src/main/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,6 @@ void dispatch(int level, CallStack callStack) {
495495
}
496496
Set<ResultPathWithDataLoader> resultPathWithDataLoaders = callStack.levelToResultPathWithDataLoader.get(level);
497497
if (resultPathWithDataLoaders != null) {
498-
profiler.chainedStrategyDispatching(level);
499498
Set<String> resultPathToDispatch = callStack.lock.callLocked(() -> {
500499
callStack.dispatchingStartedPerLevel.add(level);
501500
return resultPathWithDataLoaders

src/test/groovy/graphql/ProfilerTest.groovy

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,6 @@ class ProfilerTest extends Specification {
437437
batchLoadCalls == 2
438438
profilerResult.isDataLoaderChainingEnabled()
439439
profilerResult.getDataLoaderLoadInvocations() == [name: 4]
440-
profilerResult.getChainedStrategyDispatching() == [1] as Set
441440
profilerResult.getDispatchEvents().size() == 2
442441
profilerResult.getDispatchEvents()[0].dataLoaderName == "name"
443442
profilerResult.getDispatchEvents()[0].level == 1

0 commit comments

Comments
 (0)