fix: Preserve entity row order in precomputed reads - #6806
Open
JodeZer wants to merge 1 commit into
Open
Conversation
Signed-off-by: JodeZer <jeffery1993@hotmail.com>
JodeZer
requested review from
franciscojavierarceo,
ntkathole and
tokoko
and removed request for
a team
September 1, 2026 10:08
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Precomputed online retrieval deduplicates and sorts entity keys before reading their vectors. The fast path previously wrote those vectors into response rows by enumeration order instead of mapping them back to the original request rows. Unsorted requests could therefore receive another entity's features, and repeated entities were not fanned out to every requested row.
This is a user-facing correctness fix. It passes the entity-to-request-row mapping into the precomputed fast path and scatters values, field statuses, and timestamps back to their original positions while preserving the existing deduplicated read and parse behavior.
Both synchronous and asynchronous public
get_online_featurespaths are covered.Which issue(s) this PR fixes:
Fixes #6805
The affected precomputed path was introduced by #6463 for #6185.
Checks
git commit -s)Testing Strategy
Successful checks:
The full
make test-python-unitrun completed with 2630 passed and 17 skipped, but exited nonzero with 17 failures and 22 errors unrelated to the changed files. Local failures were confined to existing environment-sensitive areas: SQLite extension loading, CLI repository templates, Docling dependency compatibility, and MongoDB test-container port mapping. All 62 tests in the modified precomputed suite passed within that full run.Misc
No public API, protobuf, storage schema, or dependency changes.
Release note