test: refactor root conftest.py — move fixtures to universal/, remove marker filtering (#6053) - #6804
Open
GANESH-NADKARNI wants to merge 2 commits into
Open
Conversation
…k integration test to component/flink Signed-off-by: GANESH NADKARNI <ganeshnadkarni369@gmail.com>
…6052's own investigation notes Signed-off-by: GANESH NADKARNI <ganeshnadkarni369@gmail.com>
GANESH-NADKARNI
force-pushed
the
fix/6053-conftest-refactor
branch
from
September 1, 2026 07:40
f5432f5 to
ad81fb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6053.
Moves the fixtures listed in the issue (
environment,vectordb_environment,universal_data_sources,e2e_data_sources,feature_server_endpoint,feature_store_for_online_retrieval,fake_ingest_data,fake_document_data,fake_image_data) pluspytest_generate_testsand their supporting helpers (_load_universal_feature_repo_deps,start_test_local_server) into a newtests/universal/conftest.py, since they're hard dependencies of the fixtures being moved.Deletes
pytest_collection_modifyitemsand the--integrationCLI option from rootconftest.py, per the issue.Keeps
simple_dataset_1/2,temp_dir,server_port,feature_store,auth_config,tls_mode, and marker registrations in root, as specified.Additional fixes found during validation:
Removing the marker-filtering logic exposed two mis-tiered files that were previously silently protected by it:
tests/unit/infra/compute_engines/flink/test_flink_compute_engine.pycontained one@pytest.mark.integrationtest whose presence intests/unitwas masked by the old filtering. Moved the whole file totests/component/flink/, matching the existing precedent from [Test restructure 2] Move ray and spark tests to component/* #6050 (component/ray,component/spark) — no test content changed.tests/unit/test_rest_error_decorator.pyuses theenvironmentfixture with no markers — this file is explicitly named in [Test restructure 4] Reclassify misplaced tests at the unit/integration boundary #6052's own investigation table as needing this exact fix ("move to universal/" was one of the two suggested options). Moved it totests/universal/accordingly — no test content changed.Validation:
pytest tests/unitbefore and after this change shows identical failure/error signatures (105 failed, 42 errors), confirming no functional changes — only reorganization, as required by the migration principles in #6048.