fix: Merge shared ODFV source projections in feature resolution - #6622
Merged
ntkathole merged 1 commit intoJul 30, 2026
Merged
Conversation
sanskar-singh-2403
force-pushed
the
fix/odfv-shared-source-projection-merge
branch
from
July 22, 2026 05:47
072cf48 to
621c1b1
Compare
Contributor
Author
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6622 +/- ##
==========================================
+ Coverage 46.35% 46.37% +0.01%
==========================================
Files 414 414
Lines 50052 50069 +17
Branches 7151 7153 +2
==========================================
+ Hits 23201 23217 +16
- Misses 25229 25230 +1
Partials 1622 1622
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Author
addenergyx
reviewed
Jul 23, 2026
sanskar-singh-2403
force-pushed
the
fix/odfv-shared-source-projection-merge
branch
3 times, most recently
from
July 25, 2026 22:00
d93d559 to
ea94468
Compare
Contributor
Author
|
@franciscojavierarceo @ntkathole requesting your reviews in this, Thanks! |
ntkathole
approved these changes
Jul 30, 2026
ntkathole
force-pushed
the
fix/odfv-shared-source-projection-merge
branch
from
July 30, 2026 06:26
ea94468 to
b4feda7
Compare
When several on demand feature views share a source feature view but select different input columns, _get_feature_views_to_use appended the shared source view once per ODFV, each copy carrying only that ODFV's projection. The membership check 'if source_fv not in fvs_to_use' never matched because BaseFeatureView.__eq__ compares projections and the freshly fetched full-projection view never equals a stored narrowed copy. Downstream, _group_feature_refs keys its view index by projection.name_to_use(), so the last duplicate won and the other ODFVs' source projections were silently dropped, producing missing inputs (NaN in pandas mode) during retrieval. Index accumulated source views by projection.name_to_use() and merge projections (union of features, deduped by name) instead of appending a duplicate, so a shared source view resolves to a single entry carrying the union of the required input columns. The merge helper reassigns projection.features to a fresh list rather than mutating in place, because the projections in play are shallow copies (copy.copy) that share their features list with the registry object. Adds TestGetFeatureViewsToUseSharedSource in tests/unit/test_utils.py covering the merged-projection result and order independence. Fixes feast-dev#6621 Signed-off-by: Sanskar Singh <sanskarsinghty1234@gmail.com>
ntkathole
force-pushed
the
fix/odfv-shared-source-projection-merge
branch
from
July 30, 2026 08:30
b4feda7 to
da47014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes #6621.
When several on demand feature views share a source feature view but select different input columns, _get_feature_views_to_use appended the shared source view once per ODFV, each copy carrying only that ODFV's projection. The membership guard if source_fv not in fvs_to_use never matched, because BaseFeatureView.eq compares projections and the freshly-fetched full-projection view never equals an already-stored narrowed copy.
Downstream, _group_feature_refs keys its view index by projection.name_to_use(), so the duplicate entries collide and the last one wins, the other ODFVs' source projections are silently dropped. During get_historical_features this means the losing ODFV's input columns are never fetched, so transforms receive missing inputs (NaN in pandas mode).
The offline retrieval path is masked on 0.62+ by the ref-injection loop from #6140, but the resolution helper still returns duplicate entries with conflicting projections to its other callers (_get_online_request_context, retrieve_online_documents, retrieve_online_documents_v2).
The fix
In _get_feature_views_to_use, index accumulated source views by projection.name_to_use() and, on a repeat hit, merge the projections (union of features, deduped by name) instead of appending a duplicate. A shared source view now resolves to a single entry carrying the union of the required input columns.
The merge helper reassigns projection.features to a fresh list rather than mutating in place, because the projections in play are shallow copies (copy.copy) that share their features list with the registry object.
Tests
Added TestGetFeatureViewsToUseSharedSource in tests/unit/test_utils.py:
Both fail on master (assert 2 == 1 the duplicate entries) and pass with this change. ruff check and ruff format are clean.
Related
#6099, #6140