Skip to content

Match CPython on code objects, ast, symtable and syntax error positions #8580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 12 commits into from
Aug 23, 2026
Merged

Match CPython on code objects, ast, symtable and syntax error positions #8580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
24048ea
Guard all/any/tuple(genexpr) calls when the generator is a coroutine
youknowone Aug 20, 2026
2b75cac
Name the ellipsis type `ellipsis`
youknowone Aug 21, 2026
569cc05
Align compiler front end and instruction positions with CPython
youknowone Aug 21, 2026
7cf03aa
Align ast module output with CPython
youknowone Aug 21, 2026
7a7ef48
Align symbol table output with CPython
youknowone Aug 21, 2026
4fa2f52
Locate the eval return and the interactive print like CPython
youknowone Aug 22, 2026
6fabab6
Give interactive mode the conditional annotations cell
youknowone Aug 22, 2026
f1b9311
Give compiler-raised SyntaxErrors an end position
youknowone Aug 22, 2026
2f125c2
Report parser diagnostics with CPython's wording
youknowone Aug 22, 2026
ec99450
Punctuate the code object repr like CPython
youknowone Aug 22, 2026
fa71120
Match CPython's parser error positions
youknowone Aug 22, 2026
73f3f65
codegen: seek to the finally body's own scopes before copying it
youknowone Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
"emscripten",
"excs",
"fdigits",
"feff",
"flufl",
"fnfe",
"fsdefault",
Expand Down
6 changes: 0 additions & 6 deletions Lib/test/test_dis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,7 +1106,6 @@ def f():
def test_bug_708901(self):
self.do_disassembly_test(bug708901, dis_bug708901)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_bug_1333982(self):
# This one is checking bytecodes generated for an `assert` statement,
# so fails if the tests are run with -O. Skip this test then.
Expand Down Expand Up @@ -1164,7 +1163,6 @@ def func(count):
from test import dis_module
self.do_disassembly_test(dis_module, dis_module_expected_results)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_disassemble_str(self):
self.do_disassembly_test(expr_str, dis_expr_str)
self.do_disassembly_test(simple_stmt_str, dis_simple_stmt_str)
Expand Down Expand Up @@ -1251,7 +1249,6 @@ def test_dis_traceback(self):
def test_dis_object(self):
self.assertRaises(TypeError, dis.dis, object())

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_disassemble_recursive(self):
def check(expected, **kwargs):
dis = self.get_disassembly(_h, **kwargs)
Expand Down Expand Up @@ -1623,13 +1620,11 @@ class CodeInfoTests(unittest.TestCase):
(async_def, code_info_async_def)
]

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_code_info(self):
self.maxDiff = 1000
for x, expected in self.test_pairs:
self.assertRegex(dis.code_info(x), expected)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_show_code(self):
self.maxDiff = 1000
for x, expected in self.test_pairs:
Expand Down Expand Up @@ -2322,7 +2317,6 @@ def test_source_line_in_disassembly(self):
actual = actual.strip().partition(" ")[0] # extract the line no
self.assertEqual(actual, "350")

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_info(self):
self.maxDiff = 1000
for x, expected in CodeInfoTests.test_pairs:
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2453,7 +2453,6 @@ def try_compile(source):
self.assertEqual(exc.offset, 1)
self.assertEqual(exc.end_offset, 12)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_file_source(self):
self.addCleanup(unlink, TESTFN)
err = run_script('return "ä"')
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_fstring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,6 @@ def test_ast_line_numbers_multiline_fstring(self):
self.assertEqual(t.body[0].value.values[1].value.col_offset, 11)
self.assertEqual(t.body[0].value.values[1].value.end_col_offset, 16)

@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: 4 != 5
def test_ast_line_numbers_with_parentheses(self):
expr = """
x = (
Expand Down
3 changes: 0 additions & 3 deletions Lib/test/test_json/test_default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
import collections
from test.test_json import PyTest, CTest

import unittest # XXX: RUSTPYTHON; importing to be able to skip tests


class TestDefault:
def test_default(self):
self.assertEqual(
self.dumps(type, default=repr),
self.dumps(repr(type)))

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_bad_default(self):
def default(obj):
if obj is NotImplemented:
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_syntax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@
SyntaxError: Generator expression must be parenthesized
>>> f((x for x in L), 1)
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
>>> class C(x for x in L): # TODO: RUSTPYTHON; Wrong error message # doctest: +EXPECTED_FAILURE
>>> class C(x for x in L):
... pass
Traceback (most recent call last):
SyntaxError: invalid syntax
Expand Down
Loading
Loading