Skip to content

Expose symbol scopes through _symtable - #8538

Merged
youknowone merged 1 commit into
RustPython:mainfrom
YangSiJun528:expose-symtable-scopes
Aug 17, 2026
Merged

Expose symbol scopes through _symtable#8538
youknowone merged 1 commit into
RustPython:mainfrom
YangSiJun528:expose-symtable-scopes

Conversation

@YangSiJun528

@YangSiJun528 YangSiJun528 commented Aug 16, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

_symtable omitted symbol scope information, causing Lib/symtable.py to report incorrect globals, locals, and free variables.

Expose the missing scope information so the public symtable API returns CPython-compatible results.

Testing

  • cargo run --release -- -m test test_symtable

AI assistance

Codex (GPT-5) was used to investigate and implement this change.
I reviewed and validated all AI-assisted work.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected symbol table results to include both symbol flags and scope information.
    • Improved the accuracy of symbol metadata returned to callers.

@YangSiJun528
Expose symbol scopes through _symtable
62dd3ca 
Pack symbol scopes with definition flags in _symtable.symbols for
Lib/symtable.py.

Assisted-by: Codex:gpt-5
@github-actions github-actions Bot added the z-ca-2026 Tag to track Contribution Academy 2026 label Aug 16, 2026
@coderabbitai

coderabbitai Bot commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3aa4bb6f-4909-448f-8395-028131f51fec

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between aaeab4f and 62dd3ca.

β›” Files ignored due to path filters (1)
  • Lib/test/test_symtable.py is excluded by !Lib/**
πŸ“’ Files selected for processing (1)
  • crates/vm/src/stdlib/_symtable.rs

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.

πŸ“ Walkthrough

Walkthrough

PySymbolTable.symbols now returns symbol flags combined with the symbol scope shifted by SCOPE_OFFSET.

Changes

Symbol scope encoding

Layer / File(s) Summary
Encode symbol scope values
crates/vm/src/stdlib/_symtable.rs		 PySymbolTable.symbols combines each symbol’s flag bits with its shifted scope classification.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: βšͺ Minimal Β· up to 62dd3

This is a localized behavior fix with no actionable merge-blocking risk remaining; merge after normal formatting and lint checks.

Possibly related PRs

Suggested reviewers: shaharnaveh, youknowone

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The title clearly and concisely describes the main change: exposing symbol scopes through _symtable.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

πŸ“¦ Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/symtable.py
[x] test: cpython/Lib/test/test_symtable.py (TODO: 5)

dependencies:

  • symtable

dependent tests: (2 tests)

  • symtable: test_inspect test_symtable

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

ShaharNaveh
ShaharNaveh approved these changes Aug 16, 2026
View reviewed changes

@ShaharNaveh ShaharNaveh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”₯

ty for looking into it:)

@youknowone
youknowone merged commit 25e76af into RustPython:main Aug 17, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

@YangSiJun528 YangSiJun528

Labels

z-ca-2026 Tag to track Contribution Academy 2026

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YangSiJun528 @ShaharNaveh @youknowone