Skip to content

Uncomment codegen crashing tests - #8175

Merged
youknowone merged 5 commits into
RustPython:mainfrom
ShaharNaveh:update-test-patma
Jun 30, 2026
Merged

Uncomment codegen crashing tests#8175
youknowone merged 5 commits into
RustPython:mainfrom
ShaharNaveh:update-test-patma

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

These tests were causing RustPython to crash during the codegen phase, which is no longer the case

These no longer crash RustPython after #8138 (most likely)

@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

β›” Files ignored due to path filters (5)
  • Lib/test/test_grammar.py is excluded by !Lib/**
  • Lib/test/test_listcomps.py is excluded by !Lib/**
  • Lib/test/test_patma.py is excluded by !Lib/**
  • Lib/test/test_pep646_syntax.py is excluded by !Lib/**
  • Lib/test/test_super.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

βš™οΈ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 6d99608a-1a21-44dd-836b-e99395e439ea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • πŸ” Trigger review
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

πŸ“¦ Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] test: cpython/Lib/test/test_grammar.py

dependencies:

dependent tests: (no tests depend on grammar)

[x] test: cpython/Lib/test/test_list.py (TODO: 4)
[x] test: cpython/Lib/test/test_listcomps.py (TODO: 1)
[ ] test: cpython/Lib/test/test_userlist.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on list)

[x] test: cpython/Lib/test/test_patma.py

dependencies:

dependent tests: (no tests depend on patma)

[x] test: cpython/Lib/test/test_super.py (TODO: 3)

dependencies:

dependent tests: (no tests depend on super)

[x] test: cpython/Lib/test/test_pep646_syntax.py

dependencies:

dependent tests: (no tests depend on pep646_syntax)

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@ShaharNaveh
ShaharNaveh marked this pull request as ready for review June 27, 2026 08:56
@youknowone
youknowone merged commit ba23db2 into RustPython:main Jun 30, 2026
32 of 33 checks passed
@youknowone

youknowone commented Jun 30, 2026

Copy link
Copy Markdown
Member

awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone